Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range3d, Area, and AreaOfInterest #20

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Range3d, Area, and AreaOfInterest #20

merged 4 commits into from
Jun 24, 2024

Conversation

sgwilym
Copy link
Contributor

@sgwilym sgwilym commented Jun 23, 2024

Implement Range3d

  • Added Range3d struct with includes_entry and intersection methods, Default impl.
  • Range::includes no longer moves the value being tested for inclusion
  • Add Clone trait bound to NamespaceId, SubspaceId, PayloadDigest

Implement AreaSubspace, Area

  • Add AreaSubspace with includes and intersection methods
  • Add Area with full, subspace, includes_entry, and intersection methods.

Implement AreaOfInterest

  • Add AreaOfInterest with intersection method.

sgwilym added 3 commits June 23, 2024 11:04
@sgwilym
Add Range3d
d0de979 
- Added `Range3d` struct with `includes_entry` and `intersection` methods, `Default` impl.
- `Range::includes` no longer moves the value being tested for inclusion
- Add Clone trait bound to NamespaceId, SubspaceId, PayloadDigest
@sgwilym
Implement AreaSubspace, Area
6ac0be2 
- Add `AreaSubspace` with `includes` and `intersection` methods
- Add `Area` with `full`, `subspace`, `includes_entry`, and `intersection` methods.
@sgwilym
Add AreaOfInterest
965f565
@sgwilym sgwilym added the enhancement New feature or request label Jun 23, 2024
@sgwilym sgwilym merged commit 6fedd72 into main Jun 24, 2024
1 check passed
@sgwilym sgwilym deleted the 3d-range-and-areas branch June 24, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mycognosist mycognosist mycognosist left review comments

@AljoschaMeyer AljoschaMeyer AljoschaMeyer left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Willow Data Model - Rust
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sgwilym @AljoschaMeyer @mycognosist