Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zlib dependency to YODA and Rivet #19679

Merged

Conversation

APN-Pucky
Copy link
Contributor

@APN-Pucky APN-Pucky commented Jan 22, 2024

Problem in EESSI EESSI/software-layer#418
(created using eb --new-pr)

@casparvl
Copy link
Contributor

I can confirm that it is now picking up the correct zlib for regular EB useage (i.e. without --filter-deps=zlib). We already confirmed it works with --filter-deps=zlib in this build for EESSI.

I'll upload a test report from my regular cluster.

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19679 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19679 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12704

Test results coming soon (I hope)...

- notification for comment with ID 1907960988 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/50a89a5e78d7affee1ffb49c356d3f89 for a full test report.

@APN-Pucky
Copy link
Contributor Author

This is unfortunately a problem with hepforge.org, it is occasionally not available or takes a bit long to respond. As seen in end of the partial log here https://gist.github.com/boegelbot/8403a94ae031e40ad037ffcb415c5313

@boegel boegel added the bug fix label Jan 24, 2024
@boegel boegel added this to the release after 4.9.0 milestone Jan 24, 2024
@casparvl
Copy link
Contributor

Hm, yeah, I had the same problem locally. Then I downloaded it with wget manually and it worked on the second try...

I'm not quite sure why it fails with EasyBuild, I seem to have consistent failures for Rivet 3.1.9 on my local system, and consistent successes when I try with wget. Well, anyway, I'll try to trigger the bot a few more times, see if we randomly get a succes. It should at least cache the sources, so the 2 that already succeeeded should keep succeeding :)

@casparvl
Copy link
Contributor

@boegelbot please test @ generoso

@casparvl
Copy link
Contributor

In the meantime: maybe you can also upload a test report from your own system? If I can't get the boegelbot build to work, at least we could still get 2 succesful test reports (from your system and my system).

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on login1

PR test command 'EB_PR=19679 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs /opt/software/slurm/bin/sbatch --job-name test_PR_19679 --ntasks=4 ~/boegelbot/eb_from_pr_upload_generoso.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 12712

Test results coming soon (I hope)...

- notification for comment with ID 1908318760 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
FAILED
Build succeeded for 2 out of 4 (4 easyconfigs in total)
cns1 - Linux Rocky Linux 8.5, x86_64, Intel(R) Xeon(R) CPU E5-2667 v3 @ 3.20GHz (haswell), Python 3.6.8
See https://gist.github.com/boegelbot/7e603446758fafcc9494b883f45e61e3 for a full test report.

@casparvl
Copy link
Contributor

@boegelbot please test @ jsc-zen3

@boegelbot
Copy link
Collaborator

@casparvl: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ develop != 'develop' ]]; then EB_BRANCH=develop ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/develop source init_env_easybuild_develop.sh; fi; EB_PR=19679 EB_ARGS= EB_CONTAINER= EB_REPO=easybuild-easyconfigs EB_BRANCH=develop /opt/software/slurm/bin/sbatch --job-name test_PR_19679 --ntasks=8 ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3467

Test results coming soon (I hope)...

- notification for comment with ID 1908387394 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
gcn6.local.snellius.surf.nl - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz, 4 x NVIDIA NVIDIA A100-SXM4-40GB, 545.23.08, Python 3.6.8
See https://gist.github.com/casparvl/8f0626a697d27d257da1ea69a3175e4e for a full test report.

@boegelbot
Copy link
Collaborator

Test report by @boegelbot
SUCCESS
Build succeeded for 4 out of 4 (4 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/1b3c3f38ab53c573732539e86c698ed1 for a full test report.

Copy link
Contributor

@casparvl casparvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Awaiting a final test build I'm doing...

@casparvl
Copy link
Contributor

Test report by @casparvl
SUCCESS
Build succeeded for 6 out of 6 (2 easyconfigs in total)
x86-64-amd-zen2-node1.int.aws-rocky88-202310.eessi.io - Linux Debian GNU/Linux 11 (bullseye), x86_64, AMD EPYC 7R32 (zen2), Python 3.11.4
See https://gist.github.com/casparvl/666ae0185e3fa130c04c2db2ccf03b2b for a full test report.

@jfgrimm
Copy link
Member

jfgrimm commented Jan 24, 2024

Test report by @jfgrimm
SUCCESS
Build succeeded for 13 out of 13 (4 easyconfigs in total)
gpu07.viking2.yor.alces.network - Linux Rocky Linux 8.8, x86_64, AMD EPYC 7643 48-Core Processor, 2 x NVIDIA NVIDIA A40, 535.86.10, Python 3.6.8
See https://gist.github.com/jfgrimm/df88c4ae56668cf442f2d2742f1cd60e for a full test report.

@casparvl
Copy link
Contributor

Going in, thanks @APN-Pucky!

@casparvl casparvl merged commit 27a199b into easybuilders:develop Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants