Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nightingale upgrade #820

Merged
merged 192 commits into from
Dec 17, 2024
Merged

Nightingale upgrade #820

merged 192 commits into from
Dec 17, 2024

Conversation

dlrice
Copy link
Contributor

@dlrice dlrice commented Oct 21, 2024

Notes

  • Apologies but this PR includes changes from the tooltip PR which as already been approved. Somehow I can't disregard those changes here.
  • Some delay on the MSA loading in alignment overview. I will continue to look at this as I assume the change will want to be made in the nightingale codebase.

Purpose

Upgrade to the latest nightingale v5

Approach

  • Upgrade protvista packages to the latest nightingale
    • Feature.accession now acts as the protvista feature ID
    • displaystart --> display-start / displayend --> display-end
  • Replace protvista-datatable with new React component TableFromData.
    • This has the consumer provide a column configuration similar to our results tables.
    • Table rows which are in range or are active are now managed using props markBackground and markBorder
  • Incorporate tooltips everywhere using the new tooltip.ts functions which are based on floating-ui.
  • Update to latest protvista-uniprot and adapt filtering logic
  • Saw repeated attempts to reregister nightingale components so adapted the global customElements.define to make sure this doesn't happen. I did spend some time trying to figure out why this was happening but couldn't find the source.

Follow on tasks

Testing

Added and updated.

Checklist

  • My PR is scoped properly, and “does one thing only”
  • I have reviewed my own code
  • I have checked that linting checks pass and type safety is respected
  • I have checked that tests pass and coverage has at least improved, and if not explained the reasons why

@dlrice dlrice mentioned this pull request Nov 12, 2024
4 tasks
src/shared/utils/tooltip.ts Outdated Show resolved Hide resolved
src/shared/utils/tooltip.ts Outdated Show resolved Hide resolved
function hideTooltip(e?: Event) {
const target = e?.target as Node;
// f scroll/wheel is within the tooltip element, do not remove the tooltip
if (target && !tooltip.contains(target)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems duplicated by L183?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that' right. There is no need for two separate functions. hideTooltip is complete. Do you have any suggestion for a name of the event handler?

@dlrice dlrice merged commit 5eddfcb into main Dec 17, 2024
1 check passed
@dlrice dlrice deleted the nightingale branch December 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants