-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nightingale upgrade #820
Nightingale upgrade #820
Conversation
function hideTooltip(e?: Event) { | ||
const target = e?.target as Node; | ||
// f scroll/wheel is within the tooltip element, do not remove the tooltip | ||
if (target && !tooltip.contains(target)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems duplicated by L183?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that' right. There is no need for two separate functions. hideTooltip is complete. Do you have any suggestion for a name of the event handler?
Notes
Purpose
Upgrade to the latest nightingale v5
Approach
protvista-datatable
with new React componentTableFromData
.markBackground
andmarkBorder
tooltip.ts
functions which are based on floating-ui.customElements.define
to make sure this doesn't happen. I did spend some time trying to figure out why this was happening but couldn't find the source.Follow on tasks
Testing
Added and updated.
Checklist