Skip to content

Commit

Permalink
Revert "Set sideEffects to false for all packages."
Browse files Browse the repository at this point in the history
This reverts commit a4c7230.
  • Loading branch information
dlrice committed Jan 13, 2025
1 parent 638b4bf commit 32ace78
Show file tree
Hide file tree
Showing 59 changed files with 7,469 additions and 2,651 deletions.
62 changes: 31 additions & 31 deletions .storybook/main.js
Original file line number Diff line number Diff line change
@@ -1,40 +1,40 @@
import { dirname, join } from "path";
import remarkGfm from "remark-gfm";
const path = require("path");

module.exports = {
stories: ["../stories/**/*.mdx", "../stories/**/*.stories.@(js|jsx|ts|tsx)"],

stories: [
"../stories/**/*.stories.mdx",
"../stories/**/*.stories.@(js|jsx|ts|tsx)",
],
addons: [
getAbsolutePath("@storybook/addon-links"),
getAbsolutePath("@storybook/addon-essentials"),
getAbsolutePath("@storybook/addon-a11y"),
getAbsolutePath("@storybook/addon-storysource"),
getAbsolutePath("@storybook/addon-actions"),
getAbsolutePath("@storybook/addon-mdx-gfm"),
{
name: "@storybook/addon-docs",
options: {
mdxPluginOptions: {
mdxCompileOptions: {
remarkPlugins: [remarkGfm],
},
},
},
},
"@storybook/addon-links",
"@storybook/addon-essentials",
"@storybook/addon-a11y",
"@storybook/addon-storysource",
"@storybook/addon-actions",
],

typescript: {
check: false,
},

framework: {
name: getAbsolutePath("@storybook/web-components-vite"),
options: {},
core: {
builder: "webpack5",
},
webpackFinal: (config) => {
config.resolve.alias = {
...config.resolve.alias,
"@nightingale-elements/nightingale-new-core": path.resolve(
__dirname,
"../packages/nightingale-new-core/src/index.ts",
),
};
config.module.rules.push({
test: /\.(ts|tsx)$/,
include: path.resolve(__dirname, "../packages"),
loader: "ts-loader",
});
config.module.rules.push({
test: /\.(tsv)$/,
type: "asset/source",
});
return config;
},

docs: {},
};

function getAbsolutePath(value) {
return dirname(require.resolve(join(value, "package.json")));
}
1 change: 0 additions & 1 deletion .storybook/preview.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,3 @@ export const parameters = {
},
},
};
export const tags = ["autodocs"];
2 changes: 1 addition & 1 deletion lerna.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"packages": ["packages/*"],
"npmClient": "yarn",
"concurrency": 4,
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"$schema": "node_modules/lerna/schemas/lerna-schema.json"
}
35 changes: 15 additions & 20 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,31 +18,29 @@
"serve": "wds --node-resolve --watch",
"serve:prod": "MODE=prod yarn serve",
"checksize": "rollup -c ; cat my-element.bundled.js | gzip -9 | wc -c ; rm my-element.bundled.js",
"storybook": "storybook dev -p 6006",
"build-storybook": "storybook build"
"storybook": "start-storybook -p 6006",
"build-storybook": "build-storybook"
},
"license": "MIT",
"resolutions": {
"@storybook/{app}/webpack": "5.91.0"
},
"devDependencies": {
"@babel/core": "7.24.5",
"@codesandbox/sandpack-react": "2.13.10",
"@custom-elements-manifest/analyzer": "0.10.2",
"@mdx-js/rollup": "^3.1.0",
"@rollup/plugin-commonjs": "25.0.7",
"@rollup/plugin-json": "6.1.0",
"@rollup/plugin-node-resolve": "15.2.3",
"@rollup/plugin-typescript": "11.1.6",
"@storybook/addon-a11y": "^8.4.7",
"@storybook/addon-actions": "^8.4.7",
"@storybook/addon-docs": "^8.4.7",
"@storybook/addon-essentials": "^8.4.7",
"@storybook/addon-links": "^8.4.7",
"@storybook/addon-mdx-gfm": "^8.4.7",
"@storybook/addon-storysource": "^8.4.7",
"@storybook/addons": "6.5.16",
"@storybook/core-server": "^8.4.7",
"@storybook/mdx2-csf": "^1.1.0",
"@storybook/web-components": "^8.4.7",
"@storybook/web-components-vite": "^8.4.7",
"@storybook/addon-a11y": "6.5.16",
"@storybook/addon-actions": "6.5.16",
"@storybook/addon-essentials": "6.5.16",
"@storybook/addon-links": "6.5.16",
"@storybook/addon-storysource": "6.5.16",
"@storybook/builder-webpack5": "6.5.16",
"@storybook/manager-webpack5": "6.5.16",
"@storybook/web-components": "6.5.16",
"@types/d3": "7.4.3",
"@types/jest": "29.5.12",
"@types/lodash-es": "4.17.12",
Expand All @@ -62,17 +60,14 @@
"prettier": "3.2.5",
"rimraf": "5.0.5",
"rollup": "4.17.2",
"rollup-plugin-css-only": "^4.5.2",
"rollup-plugin-esbuild": "^6.1.1",
"rollup-plugin-css-only": "4.5.2",
"rollup-plugin-terser": "7.0.2",
"rollup-plugin-web-worker-loader": "1.6.1",
"storybook": "^8.4.7",
"ts-jest": "29.1.2",
"ts-loader": "9.5.1",
"tslib": "2.6.2",
"typescript": "5.4.5",
"vite": "^6.0.7",
"vite-plugin-dts": "^4.5.0"
"webpack": "5.91.0"
},
"workspaces": [
"packages/*"
Expand Down
9 changes: 4 additions & 5 deletions packages/nightingale-colored-sequence/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-colored-sequence",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"description": "Track that colors each base by a given function. The default function is hydrophobicity",
"files": [
"dist",
Expand All @@ -17,8 +17,8 @@
"author": "Gustavo Salazar <gsalazar@ebi.ac.uk>",
"license": "ISC",
"dependencies": {
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-sequence": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-new-core": "^5.4.0",
"@nightingale-elements/nightingale-sequence": "^5.4.0",
"d3": "7.9.0"
},
"repository": {
Expand All @@ -36,6 +36,5 @@
"customelements",
"webcomponents",
"nightingale"
],
"sideEffects": false
]
}
7 changes: 3 additions & 4 deletions packages/nightingale-filter/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-filter",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"description": "Filter component",
"files": [
"dist",
Expand All @@ -17,16 +17,15 @@
"access": "public"
},
"dependencies": {
"@nightingale-elements/nightingale-manager": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-manager": "^5.4.0",
"@nightingale-elements/nightingale-new-core": "^5.4.0",
"lodash-es": "4.17.11"
},
"keywords": [
"nightingale",
"customelements",
"webcomponents"
],
"sideEffects": false,
"repository": {
"type": "git",
"url": "https://github.com/ebi-webcomponents/nightingale.git"
Expand Down
5 changes: 2 additions & 3 deletions packages/nightingale-heatmap/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-heatmap",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"files": [
"dist",
"src"
Expand All @@ -23,7 +23,6 @@
"heatmap",
"contacts"
],
"sideEffects": false,
"repository": {
"type": "git",
"url": "https://github.com/ebi-webcomponents/nightingale.git"
Expand All @@ -33,7 +32,7 @@
},
"homepage": "https://ebi-webcomponents.github.io/nightingale/",
"dependencies": {
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-new-core": "^5.4.0",
"d3": "7.9.0"
}
}
7 changes: 3 additions & 4 deletions packages/nightingale-interpro-track/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-interpro-track",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"description": "Interpro extension of the track type.",
"files": [
"dist",
Expand All @@ -27,15 +27,14 @@
"webcomponents",
"customelements"
],
"sideEffects": false,
"author": "Gustavo Salazar <gsalazar@ebi.ac.uk>",
"license": "ISC",
"publishConfig": {
"access": "public"
},
"dependencies": {
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-track": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-new-core": "^5.4.0",
"@nightingale-elements/nightingale-track": "^5.4.0",
"d3": "7.9.0",
"lodash-es": "4.17.15"
}
Expand Down
5 changes: 2 additions & 3 deletions packages/nightingale-linegraph-track/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@nightingale-elements/nightingale-linegraph-track",
"description": "Nightingale Line Graph",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"files": [
"dist",
"src"
Expand All @@ -20,7 +20,6 @@
"line",
"graph"
],
"sideEffects": false,
"repository": {
"type": "git",
"url": "https://github.com/ebi-webcomponents/nightingale.git"
Expand All @@ -33,7 +32,7 @@
"access": "public"
},
"dependencies": {
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-new-core": "^5.4.0",
"d3": "7.9.0"
}
}
7 changes: 3 additions & 4 deletions packages/nightingale-links/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-links",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"files": [
"dist",
"src"
Expand All @@ -21,7 +21,6 @@
"webcomponents",
"customelements"
],
"sideEffects": false,
"repository": {
"type": "git",
"url": "https://github.com/ebi-webcomponents/nightingale.git"
Expand All @@ -31,8 +30,8 @@
},
"homepage": "https://ebi-webcomponents.github.io/nightingale/",
"dependencies": {
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-track": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-new-core": "^5.4.0",
"@nightingale-elements/nightingale-track": "^5.4.0",
"d3": "7.9.0",
"lodash-es": "4.17.15"
}
Expand Down
5 changes: 2 additions & 3 deletions packages/nightingale-manager/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-manager",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"description": "Event bus component for Nightnale",
"main": "dist/index.js",
"module": "dist/index.js",
Expand All @@ -19,7 +19,6 @@
"webcomponents",
"customelements"
],
"sideEffects": false,
"repository": {
"type": "git",
"url": "https://github.com/ebi-webcomponents/nightingale.git"
Expand All @@ -34,6 +33,6 @@
"access": "public"
},
"dependencies": {
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1"
"@nightingale-elements/nightingale-new-core": "^5.4.0"
}
}
5 changes: 2 additions & 3 deletions packages/nightingale-msa/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-msa",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"files": [
"dist",
"src"
Expand All @@ -20,7 +20,6 @@
"webcomponents",
"customelements"
],
"sideEffects": false,
"repository": {
"type": "git",
"url": "https://github.com/ebi-webcomponents/nightingale.git"
Expand All @@ -30,7 +29,7 @@
},
"homepage": "https://ebi-webcomponents.github.io/nightingale/",
"dependencies": {
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-new-core": "^5.4.0",
"d3": "7.9.0"
}
}
5 changes: 2 additions & 3 deletions packages/nightingale-navigation/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-navigation",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"description": "Navigation component for the Nightingale tool",
"main": "dist/index.js",
"module": "dist/index.js",
Expand All @@ -19,7 +19,6 @@
"customelements",
"webcomponents"
],
"sideEffects": false,
"repository": {
"type": "git",
"url": "https://github.com/ebi-webcomponents/nightingale.git"
Expand All @@ -34,7 +33,7 @@
"access": "public"
},
"dependencies": {
"@nightingale-elements/nightingale-new-core": "^5.4.1-alpha.1",
"@nightingale-elements/nightingale-new-core": "^5.4.0",
"d3": "7.9.0"
}
}
3 changes: 1 addition & 2 deletions packages/nightingale-new-core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@nightingale-elements/nightingale-new-core",
"version": "5.4.1-alpha.1",
"version": "5.4.0",
"description": "Base Elements for Nightingale Components",
"main": "dist/index.js",
"module": "dist/index.js",
Expand All @@ -26,7 +26,6 @@
"customelements",
"webcomponents"
],
"sideEffects": false,
"repository": {
"type": "git",
"url": "https://github.com/ebi-webcomponents/nightingale.git"
Expand Down
Loading

0 comments on commit 32ace78

Please sign in to comment.