Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps bump #279

Merged
merged 8 commits into from
May 23, 2024
Merged

Deps bump #279

merged 8 commits into from
May 23, 2024

Conversation

gustavo-salazar
Copy link
Contributor

Some dependencies updates and minor changes required for them.

A notable change is the we will be using Node 18 and Lit 3. The latter required a refractory of the custom decorator.

Some dependencies upgrades required more time than the one I had at the moment, so I opened issues for them: #275 #276 #277 #278

Copy link

netlify bot commented May 9, 2024

Deploy Preview for cozy-marzipan-abb3b4 ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/cozy-marzipan-abb3b4/deploys/664f55f2104d230a7f865251
😎 Deploy Preview https://deploy-preview-279--cozy-marzipan-abb3b4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@matthiasblum matthiasblum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I only added a few simple suggestions in one story to keep to code blocks aligned.

stories/002.CreatingAComponent.stories.mdx Outdated Show resolved Hide resolved
stories/002.CreatingAComponent.stories.mdx Outdated Show resolved Hide resolved
stories/002.CreatingAComponent.stories.mdx Outdated Show resolved Hide resolved
stories/002.CreatingAComponent.stories.mdx Outdated Show resolved Hide resolved
stories/002.CreatingAComponent.stories.mdx Outdated Show resolved Hide resolved
stories/002.CreatingAComponent.stories.mdx Outdated Show resolved Hide resolved
gustavo-salazar and others added 3 commits May 23, 2024 09:29
Co-authored-by: Matthias Blum <mat.blum@gmail.com>
Co-authored-by: Matthias Blum <mat.blum@gmail.com>
@gustavo-salazar gustavo-salazar merged commit d9960f7 into main May 23, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants