Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Position mapping refactor #312

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Position mapping refactor #312

merged 2 commits into from
Nov 11, 2024

Conversation

dlrice
Copy link
Contributor

@dlrice dlrice commented Nov 7, 2024

  • Refactor translatePositions so that test run goes from 15s to 5s.
  • Replace lodash's groupBy with Maps
  • Early exits when mapping found
  • Remove old file

@netlify Netlify
Copy link

netlify bot commented Nov 7, 2024 •
edited
Loading

✅ Deploy Preview for cozy-marzipan-abb3b4 ready!

Name Link
🔨 Latest commit a7a8d54
🔍 Latest deploy log https://app.netlify.com/sites/cozy-marzipan-abb3b4/deploys/672cdd1702f22900083cc13f
😎 Deploy Preview https://deploy-preview-312--cozy-marzipan-abb3b4.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@dlrice dlrice merged commit 6b73bc6 into main Nov 11, 2024
4 of 6 checks passed
@dlrice dlrice deleted the position-mapping-refactor branch November 11, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurel-l aurel-l aurel-l approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dlrice @aurel-l