Fix issue 189 #197
Fix issue 189 #197
Conversation
|
Once this gets merged I think it would be best to reorganize all files into internal/cgo and internal/nocgo so that the assembly and C files can have a clear distinction |
|
I added a |
buildtest/main.go
Outdated
| @@ -0,0 +1,17 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
There was a problem hiding this comment.
internal/buildtest would be better, as this doesn't have to be a public API to users.
There was a problem hiding this comment.
none of the other C test folders are in internal. Should the test files be moved? not in this PR ofc.
There was a problem hiding this comment.
Now the other test files are in direct children packages. These are NOT Go packages, but these also should be in internal packages IMO. Let's move buildtest into internal, and consider moving the others later.
What do you think? (I think yes) |
As long as there are no merge conflicts I think so too. |
Use the standard Cgo import mechanism when CGO_ENABLED=1. This fixes an issue where sometimes the external linker would fail to add the dlfcn symbols causing a linker error. Closes #189
This reverts commit 579fc87. Reason: go-vet fails: ``` Error: ./syscall_cgo_linux.go:14:33: undefined: cgo.Syscall9XABI0 Error: ./syscall_cgo_linux.go:25:13: undefined: cgo.Syscall9X Error: Process completed with exit code 1. ```
Use the standard Cgo import mechanism when CGO_ENABLED=1. This fixes an issue where sometimes the external linker would fail to add the dlfcn symbols causing a linker error. Closes #189
Use the standard Cgo import mechanism when CGO_ENABLED=1. This fixes an issue where sometimes the external linker would fail to add the dlfcn symbols causing a linker error. Closes #189
Use the standard Cgo import mechanism when CGO_ENABLED=1. This fixes an issue where sometimes the external linker would fail to add the dlfcn symbols causing a linker error.
Closes #189