GraphQL version of the TSP #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Simon for providing the GraphQL version of the TSP. GraphQL is interesting for the TSP for various reason. I opened an issue #45 to track the GraphQL investigation. |
|
Closing this legacy (yet way-paving) PR for the time being. Team recently resumed investigating GraphQL though, per this extension PR. More to come through the latter thread, then. |
marco-miller
added a commit
to eclipse-cdt-cloud/theia-trace-extension
that referenced
this pull request
Mar 17, 2022
Document a code example directly in ADR's text, answering its previously related question this way. This example cannot be added as actual code in the existing ADR prototype, as it requires manually provisioned test data. This would otherwise make the prototype more complex than what ADR scope prescribes. Assume usage of [1] as a mean to provision that data. Still, document how one may reproduce this example as working code, which is what was done while preparing this change anyway. Should one be willing to implement this beyond ADR scope, [2] (below) can be used as a legacy schema reference. ADR actual decisions might lead to implementing this further, for real ([2]) as opposed to this hereby trivial approach. Breakpoints are required if manually provisioning test data using [1], which otherwise deletes that data once done with steps. Unlike this added example which is GraphQL, [1]'s way of testing remains REST based. To further clarify, this example is "GraphQL" towards TSP REST client as previously prototyped. ADR scope focuses on first wrapping REST TSP with GraphQL queries from clients such as that ADR prototype: any such TSP GraphQL client may in turn rely on existing TSP REST clients, per ADR. Now, this example is barely about real GraphQL, but more about how to naively start implementing Resolvers towards more advanced GraphQL types (and variable parameters); [2] was an initial example of such types. [1] https://github.com/theia-ide/tsp-python-client/blob/master/test_tsp.py#L324 [2] eclipse-cdt-cloud/trace-server-protocol#44 Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Rodrigoplp-work
pushed a commit
to Rodrigoplp-work/theia-trace-extension
that referenced
this pull request
Mar 28, 2022
Document a code example directly in ADR's text, answering its previously related question this way. This example cannot be added as actual code in the existing ADR prototype, as it requires manually provisioned test data. This would otherwise make the prototype more complex than what ADR scope prescribes. Assume usage of [1] as a mean to provision that data. Still, document how one may reproduce this example as working code, which is what was done while preparing this change anyway. Should one be willing to implement this beyond ADR scope, [2] (below) can be used as a legacy schema reference. ADR actual decisions might lead to implementing this further, for real ([2]) as opposed to this hereby trivial approach. Breakpoints are required if manually provisioning test data using [1], which otherwise deletes that data once done with steps. Unlike this added example which is GraphQL, [1]'s way of testing remains REST based. To further clarify, this example is "GraphQL" towards TSP REST client as previously prototyped. ADR scope focuses on first wrapping REST TSP with GraphQL queries from clients such as that ADR prototype: any such TSP GraphQL client may in turn rely on existing TSP REST clients, per ADR. Now, this example is barely about real GraphQL, but more about how to naively start implementing Resolvers towards more advanced GraphQL types (and variable parameters); [2] was an initial example of such types. [1] https://github.com/theia-ide/tsp-python-client/blob/master/test_tsp.py#L324 [2] eclipse-cdt-cloud/trace-server-protocol#44 Signed-off-by: Marco Miller <marco.miller@ericsson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found these files in my computer while doing some clean up. This is a GraphQL version of the TSP. It is far from perfect or finish, but can give ideas if at some point the TSP switches to GraphQL