Setup CI workflows #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
commented
Feb 27, 2024
tortmayr
commented
- Adapt publisher name to reflect the eclipse-cdt namespace
- Disable not working test case for now
- Adapt CI workflow
- Add workflow for release
- Adapt publisher name to reflect the eclipse-cdt namespace - Disable not working test case for now - Adapt CI workflow - Add workflow for release
planger
reviewed
Feb 27, 2024
There was a problem hiding this comment.
Looks good, thank you! A few minor questions below. Before actually releasing we should clarify those. Also I'm wondering whether we should keep the original readme in place, but just add Fork by Eclipse CDT Cloud or so in the title and a section what this fork adds to the original VS Code extension?
planger
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.