Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[peer dependencies] Fix some warnings related to peer dependencies #295

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

marcdumais-work
Copy link
Contributor

What it does

Yarn provides some useful warnings once the dependencies are resolved. In some cases, it was possible to update versions of dependencies to satisfy the warnings, in some other cases I found the dependencies in question were no longer apparently used anywhere, and so I removed them.

In some cases I moved "dev" dependencies to the root package.json since they are applicable to all components in the yarn workspace (e.g. eslint related dependencies).

Also some small cleanups like removing "resolution" blocks that had no effect, as well as "engines" and "categories" blocks that are only applicable to the package.json for a vscode extension.

How to test

Make sure the repo still builds and that the tests pass.

Follow-ups

N/A

Review checklist

  • As an author, I have thoroughly tested my changes and carefully followed the instructions in this template

Yarn provides some useful warnings once the dependencies are resolved.
In some cases, it was possible to update versions of dependencies to
satisfy the warnings, in some other cases I found the dependencies in
question were no longer apparently used anywhere, and so I removed them.

In some cases I moved "dev" dependencies to the root package.json since
they are applicable to all components in the yarn workspace (e.g. eslint
related dependencies).

Also some small cleanups like removing "resolution" blocks that had no
effect, as well as "engines" and "categories" blocks that are only
applicable to the package.json for a vscode extension.

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
@marcdumais-work
Copy link
Contributor Author

IP Tickets for the dependencies that fail the license check:

This content is either not correctly mapped by the system, or requires review.
A review is required for npm/npmjs/@emotion/react/11.14.0.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18544 .
A review is required for npm/npmjs/-/react-is/19.0.0.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18545 .
A review is required for npm/npmjs/@emotion/cache/11.14.0.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18546 .
A review is required for npm/npmjs/-/react-modal/3.16.3.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18547 .
A review is required for npm/npmjs/@emotion/styled/11.14.0.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18548 .
A review is required for npm/npmjs/@emotion/use-insertion-effect-with-fallbacks/1.2.0.
A review request was created https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18549 .
A review is required for npm/npmjs/@playwright/test/1.49.1.
A review request already exists https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/18519 .

Signed-off-by: Marc Dumais <marc.dumais@ericsson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant