Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for bundles/org.eclipse.equinox.coordinator #777

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

eclipse-equinox-bot
Copy link
Contributor

The following cleanups where applied:

  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Make inner classes static where possible

@eclipse-equinox-bot
Copy link
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.coordinator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 58072c554c1d0e69e90f473e3b47dbf33f2d1196 Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <equinox-bot@eclipse.org>
Date: Mon, 27 Jan 2025 02:47:25 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.equinox.coordinator/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.coordinator/META-INF/MANIFEST.MF
index dca459444..1880f53c5 100644
--- a/bundles/org.eclipse.equinox.coordinator/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.coordinator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %bundleName
 Bundle-SymbolicName: org.eclipse.equinox.coordinator
-Bundle-Version: 1.5.300.qualifier
+Bundle-Version: 1.5.400.qualifier
 Bundle-Activator: org.eclipse.equinox.coordinator.Activator
 Bundle-Vendor: %bundleVendor
 Import-Package: org.eclipse.osgi.util;version="[1.1,2.0)",
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

Test Results

  666 files  ±0    666 suites  ±0   1h 17m 19s ⏱️ -50s
2 219 tests ±0  2 172 ✅ ±0   47 💤 ±0  0 ❌ ±0 
6 801 runs  ±0  6 658 ✅ ±0  143 💤 ±0  0 ❌ ±0 

Results for commit cc355ff. ± Comparison against base commit 3fdc70d.

@laeubi laeubi merged commit a084a1d into master Jan 27, 2025
28 of 29 checks passed
@laeubi laeubi deleted the clean-code/bundles/org.eclipse.equinox.coordinator branch January 27, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants