Clean Code for bundles/org.eclipse.equinox.launcher

[eclipse-equinox-bot]

The following cleanups where applied:

• Add missing '@Deprecated' annotations
• Add missing '@Override' annotations
• Add missing '@Override' annotations to implementations of interface methods
• Make inner classes static where possible

[eclipse-equinox-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.equinox.launcher/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 9499afdbb97cf2b2dfc77addecfabff5323c1fd9 Mon Sep 17 00:00:00 2001
From: Eclipse Equinox Bot <equinox-bot@eclipse.org>
Date: Mon, 27 Jan 2025 03:11:19 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.equinox.launcher/META-INF/MANIFEST.MF b/bundles/org.eclipse.equinox.launcher/META-INF/MANIFEST.MF
index 144333d9b..68c69d1c8 100644
--- a/bundles/org.eclipse.equinox.launcher/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.equinox.launcher/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.equinox.launcher;singleton:=true
-Bundle-Version: 1.6.900.qualifier
+Bundle-Version: 1.6.1000.qualifier
 Main-Class: org.eclipse.equinox.launcher.Main
 Bundle-Vendor: %providerName
 Bundle-RequiredExecutionEnvironment: JavaSE-1.8
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

0 files   -   666  0 suites   - 666   0s ⏱️ - 1h 18m 9s
0 tests  - 2 219  0 ✅  - 2 172  0 💤  -  47  0 ❌ ±0 
0 runs   - 6 801  0 ✅  - 6 658  0 💤  - 143  0 ❌ ±0 

Results for commit 8611ff5. ± Comparison against base commit 3fdc70d.

[laeubi]

Cleanup seem to be performed with wrong JDK version, needs a fix in tycho

[tjwatson]

Cleanup seem to be performed with wrong JDK version, needs a fix in tycho

Personally I have little use for the launcher, outside of actually launching the Eclipse Platform (IDE). There is little value in keeping the launcher itself at Java 8 since most things, besides the framework and a couple of other bundles in Equinox that are still needing Java 8. I would be fine if you want to move the Java level for the launcher itself.