Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLSP-1449 Update to latest client version #238

Merged
merged 3 commits into from
Dec 19, 2024
Merged

GLSP-1449 Update to latest client version #238

merged 3 commits into from
Dec 19, 2024

Conversation

tortmayr
Copy link
Contributor

@tortmayr tortmayr commented Dec 19, 2024

What it does

  • Update to latest client version. This aligns the used inversify version

Part of: eclipse-glsp/glsp#1449

  • Drop support for node 16

Part of: eclipse-glsp/glsp#1456

  • Update changelog

How to test

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

- Update to latest client version. This aligns the used inversify
version

Part of: eclipse-glsp/glsp#1449

- Drop support for node 16

Part of: eclipse-glsp/glsp#1456

- Update changelog
Copy link
Contributor

@martin-fleck-at martin-fleck-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to make the CI happy!

@tortmayr tortmayr force-pushed the glsp-1449 branch 2 times, most recently from 2a179f9 to 17bda56 Compare December 19, 2024 12:07
@tortmayr
Copy link
Contributor Author

Some E2E tests are flaky. I executed the test scenarios manually and everything seems to work as expected. So I opted for a test skip for now and have opened eclipse-glsp/glsp#1458 as a follow up

@tortmayr tortmayr merged commit 1877812 into master Dec 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants