Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix merge of if conditions to guard against pattern instanceof #1931

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jjohnstn
Copy link
Contributor

What it does

See issue.

How to test

See new test or issue.

Author checklist

- fix MergeConditionalBlocksCleanup to handle instanceof patterns and
  not merge them when they have same name
- add new test to CleanUpTest16
- fixes eclipse-jdt#1200
@jjohnstn jjohnstn self-assigned this Jan 13, 2025
@jjohnstn jjohnstn added the bug Something isn't working label Jan 13, 2025
@jjohnstn jjohnstn added this to the 4.35 M2 milestone Jan 13, 2025
@jjohnstn jjohnstn merged commit 0f60ce5 into eclipse-jdt:master Jan 14, 2025
10 checks passed
@jjohnstn jjohnstn deleted the mergeiffix branch January 14, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single if cleanup should not concatenate instanceofs that use pattern matching
1 participant