-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(AAS List): Handle protected repositories in aas list #77
base: dev
Are you sure you want to change the base?
Conversation
@@ -38,5 +38,26 @@ | |||
}, | |||
"settings": { | |||
"header": "Settings" | |||
}, | |||
"errors": { | |||
"unexpected-error": "Unexpected error", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We agreed some time ago that we want to use camelCase for the localization keys (sorry 😄 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
of course no problem :) I was confused because I saw both in the files I gues I had 50 % chance :D
"aas-add-error": "AAS could not be added." | ||
}, | ||
"qr-scanner": { | ||
"default-callback-error-msg": "Could not open the QR code!", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im not a fan of ripping these messages out of the QrScanner group.
For now it is fine, because the QrScanner is not fully translated, but I would highly suggest we move the error messages back, when we actually do the full change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me I just like to have errors with errors and other stuff with other stuff :) but I will move them back ;) Although I agree maybe having errors group within the QrScanner group would be even more clear. Good point!
Description
Fixes # (Issue)
Type of change
Please delete options that are not relevant.
Checklist: