Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AAS List): Handle protected repositories in aas list #77

Open
wants to merge 9 commits into
base: dev
Choose a base branch
from

Conversation

pawel-baran-se
Copy link
Contributor

@pawel-baran-se pawel-baran-se commented Jan 21, 2025

Description

  • fix - Update the AAS List when repository is secured now will ask to login
  • fix - Configured and not secured repositories are still available
  • refactor - Updated localization for NextJS in affected components
  • refactor/fix - Update error notification handling

Fixes # (Issue)

Type of change

Please delete options that are not relevant.

  • Minor change (non-breaking change, e.g. documentation adaption)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that causes existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix or my feature works
  • New and existing tests pass locally with my changes
  • My changes contain no console logs

@@ -38,5 +38,26 @@
},
"settings": {
"header": "Settings"
},
"errors": {
"unexpected-error": "Unexpected error",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed some time ago that we want to use camelCase for the localization keys (sorry 😄 )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

of course no problem :) I was confused because I saw both in the files I gues I had 50 % chance :D

"aas-add-error": "AAS could not be added."
},
"qr-scanner": {
"default-callback-error-msg": "Could not open the QR code!",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not a fan of ripping these messages out of the QrScanner group.
For now it is fine, because the QrScanner is not fully translated, but I would highly suggest we move the error messages back, when we actually do the full change.

Copy link
Contributor Author

@pawel-baran-se pawel-baran-se Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me I just like to have errors with errors and other stuff with other stuff :) but I will move them back ;) Although I agree maybe having errors group within the QrScanner group would be even more clear. Good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants