fix: adapt for npm switch in theia

[planger]

eclipse-theia/theia#14481

Contributed on behalf of STMicroelectronics

[tsmaeder]

It looks like npm hoists the electron package and binary to the root node_modules folder instead of the examples/electron. The application manager starts electron like this: This shoudl work, IMO.

        const electronCli = require.resolve('electron/cli.js', { paths: [this.pck.projectPath] });
        return this.__process.fork(electronCli, mainArgs, options);

[planger]

Thanks for looking into that @tsmaeder! Does this need to be adapted?

https://github.com/eclipse-theia/theia-e2e-test-suite/blob/main/tests/theia-app.test.ts#L23

test.beforeAll(async ({ playwright, browser }) => {
    app = await TheiaAppLoader.load({
        playwright, useElectron: { electronAppPath: 'theia/examples/electron', }, browser
    });
});

[tsmaeder]

No but there is a place where we compute the path to the electron executable relative to the electron app path. theia-app-loader.ts#127

[planger]

Ah ok, so it needs to be fixed in Theia, right? Can you please take care of the fix or should I? Thanks!