Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: fix rebuild #433

Merged
merged 1 commit into from
Jan 8, 2025
Merged

dev: fix rebuild #433

merged 1 commit into from
Jan 8, 2025

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Dec 18, 2024

What it does

The rebuild cache of Browser and Electron needs to point to the same directory, as otherwise they do not work properly: The Browser rebuild just restores the cached modules which is not possible if they do not point to the same directory.

How to test

Build the Browser app after the Electron app has been built. As the cache directory is not the same, the Browser modules will not be restored from the cache. Therefore the Browser build will use the Electron modules at build time and then crash at startup.

yarn && yarn electron build && yarn browser build && yarn browser start

Review checklist

Reminder for reviewers

The rebuild cache of Browser and Electron needs to point to the same
directory, as otherwise they do not work properly: The Browser rebuild
just restores the cached modules which is not possible if they do not
point to the same directory.
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@jfaltermeier jfaltermeier merged commit 791cfb6 into eclipse-theia:master Jan 8, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants