Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve language quick pick responsiveness #12992

Merged
merged 2 commits into from
Oct 12, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add try-finally block
  • Loading branch information
msujew committed Oct 11, 2023
commit 590129497955e5d903d63af0e41e82e4314203ff
Original file line number Diff line number Diff line change
@@ -71,9 +71,12 @@ export class VSXLanguageQuickPickService extends LanguageQuickPickService {
text: nls.localizeByDefault('Installing {0} language support...',
localizationContribution.localizedLanguageName ?? localizationContribution.languageName ?? localizationContribution.languageId),
});
const extensionUri = VSCodeExtensionUri.toUri(extension.extension.name, extension.extension.namespace).toString();
await this.pluginServer.deploy(extensionUri);
progress.cancel();
try {
const extensionUri = VSCodeExtensionUri.toUri(extension.extension.name, extension.extension.namespace).toString();
await this.pluginServer.deploy(extensionUri);
} finally {
progress.cancel();
}
}
});
}