Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent tabbing outside of dialog overlay #14647

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Prevent tabbing outside of dialog overlay #14647

merged 1 commit into from
Jan 8, 2025

Conversation

martin-fleck-at
Copy link
Contributor

What it does

Fixes #9894

How to test

  • Use TAB and SHIFT+TAB to navigate through tabbable elements in the DOM
  • Open a dialog (e.g., New Folder) and verify that if a dialog is open we only tab through elements within that dialog
  • Close and re-open dialog to see if tabbing only every works on expected elements

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

msujew
msujew approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@msujew msujew added the ui/ux issues related to user interface / user experience label Jan 7, 2025
@martin-fleck-at martin-fleck-at merged commit 11ea9e6 into master Jan 8, 2025
11 checks passed
@github-actions github-actions bot added this to the 1.58.0 milestone Jan 8, 2025
@msujew msujew deleted the GH-9894 branch January 8, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew approved these changes

Assignees
No one assigned
Labels
ui/ux issues related to user interface / user experience
Projects
PR Backlog
Archived in project
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

No focus trap in modal dialogs
2 participants
@martin-fleck-at @msujew