Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistently handle OpenAI models not supporting system messages instead of using dedicated O1 chat agent #14681

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Consistently handle OpenAI models not supporting system messages instead of using dedicated O1 chat agent #14681

merged 1 commit into from
Dec 30, 2024

Conversation

planger
Copy link
Contributor

@planger planger commented Dec 29, 2024 •
edited
Loading

What it does

Fixes #14686

How to test

  • Test OpenAI models still work as before, including their system message.
  • Test selecting o1-models for normal chat agents to confirm they now work (except they don't support streaming and thus no tool calling), but there is no need for a separate agent anymore.

Follow-ups

None

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@planger planger requested a review from JonasHelming December 29, 2024 21:13
@JonasHelming
Copy link
Contributor

Changes look great, thank you!
I would explicitly mention that the o1 agent is removed and because of this, I would be in favor of removing the "chore" and adding an issue for this PR to document this changes, as it is potentially breaking for the user.

@JonasHelming
Copy link
Contributor

One more thing: I think the checkmarks are set wrong, it does not introduce breaking changes 8the changelog is not updated), but I guess you have reviewed it :-)

@planger
fix: OpenAI models not supporting system messages
9bcef32 
* Consistently handle OpenAI LLMs that don't support system messages in OpenAI model provider
* Remove O1-specific agent as it isn't needed anymore
* Update to latest OpenAI library
* Change "system" to "developer" message role (https://cdn.openai.com/spec/model-spec-2024-05-08.html#follow-the-chain-of-command)
* Add 'o1-mini' model

Fixes eclipse-theia#14686
@planger planger force-pushed the planger/update-openai-o1 branch from 1a08a1f to 9bcef32 Compare December 30, 2024 19:26
@planger planger changed the title chore: update OpenAI package Consistently handle OpenAI models not supporting system messages instead of using dedicated O1 chat agent Dec 30, 2024
@planger planger merged commit c89f3dc into eclipse-theia:master Dec 30, 2024
11 checks passed
@github-actions github-actions bot added this to the 1.58.0 milestone Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonasHelming JonasHelming JonasHelming approved these changes

Assignees
No one assigned
Labels
TheiaAI
Projects
PR Backlog
Archived in project
Milestone
1.58.0
Development

Successfully merging this pull request may close these issues.

Consistently handle OpenAI LLMs that don't support system messages
2 participants
@planger @JonasHelming