Provide node-pty package for plugins #14720
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
added
plug-in system
msujew
force-pushed
the
msujew/provide-node-pty
branch
from
3c65c49 to
b523d2d
Compare
tsmaeder
reviewed
Jan 27, 2025
| const original = node_module._load; | ||
| node_module._load = function (request: string): unknown { | ||
| for (const filter of overrides) { | ||
| if (request === filter.package || request.endsWith(`node_modules/${filter.package}`) || request.endsWith(`node_modules\\${filter.package}`)) { |
There was a problem hiding this comment.
So if someone actually went to the trouble of packaging their own node-pty with the plugins, would our version override the packaged version? Is this what we want or should we first check if module in question can be loaded normally?
There was a problem hiding this comment.
I guess, yes. It probably makes sense to check for it first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #14714
Closes #13779
Adds a further override of the
requirefunction to the plugin host. In case anynode-ptypackage is required, it will simply return the node-pty package that is packaged with Theia.How to test
Run the steps in #14714 and see that you don't get the
requireerror.Follow-ups
We could add further dependencies in there.
Review checklist
Reminder for reviewers