GH-707: Introduced the `@theia/typehierarchy` extension. #3148

kittaakos · 2018-10-11T13:24:59Z

Extended the LSP with the type hierarchy.
From now on, a tree node can carry decoration data.
Added editor access for the current/active editors.
Wired the JDT LS type hierarchy into the application.

Closes: #707.

Signed-off-by: Akos Kitta kittaakos@typefox.io

Ready for preview:

AlexTugarev · 2018-10-11T13:55:51Z

just started testing... looks awesome!

kittaakos · 2018-10-11T14:39:13Z

When restarting the Theia backend without refreshing the browser:

root ERROR RangeError: Maximum call stack size exceeded
    at http://localhost:3000/11.bundle.js:3892:19
    at Map.forEach (<anonymous>)
    at SubTypeHierarchyFeature.push.../../node_modules/vscode-base-languageclient/lib/client.js.TextDocumentFeature.dispose (http://localhost:3000/11.bundle.js:3891:25)
    at SubTypeHierarchyFeature.push.../../packages/languages/lib/browser/typehierarchy/typehierarchy-feature.js.TypeHierarchyFeature.dispose (http://localhost:3000/36.bundle.js:381:34)
    at http://localhost:3000/36.bundle.js:628:42
    at CallbackList.../../packages/core/lib/common/event.js.CallbackList.invoke (http://localhost:3000/bundle.js:100223:39)
    at Emitter.../../packages/core/lib/common/event.js.Emitter.fire (http://localhost:3000/bundle.js:100303:36)
    at SubTypeHierarchyFeature.push.../../packages/languages/lib/browser/typehierarchy/typehierarchy-feature.js.TypeHierarchyFeature.dispose (http://localhost:3000/36.bundle.js:380:32)
    at http://localhost:3000/36.bundle.js:628:42
    at CallbackList.../../packages/core/lib/common/event.js.CallbackList.invoke (http://localhost:3000/bundle.js:100223:39)
root ERROR RangeError: Maximum call stack size exceeded
    at http://localhost:3000/11.bundle.js:3892:19
    at Map.forEach (<anonymous>)
    at SubTypeHierarchyFeature.push.../../node_modules/vscode-base-languageclient/lib/client.js.TextDocumentFeature.dispose (http://localhost:3000/11.bundle.js:3891:25)
    at SubTypeHierarchyFeature.push.../../packages/languages/lib/browser/typehierarchy/typehierarchy-feature.js.TypeHierarchyFeature.dispose (http://localhost:3000/36.bundle.js:381:34)
    at http://localhost:3000/36.bundle.js:628:42
    at CallbackList.../../packages/core/lib/common/event.js.CallbackList.invoke (http://localhost:3000/bundle.js:100223:39)
    at Emitter.../../packages/core/lib/common/event.js.Emitter.fire (http://localhost:3000/bundle.js:100303:36)
    at SubTypeHierarchyFeature.push.../../packages/languages/lib/browser/typehierarchy/typehierarchy-feature.js.TypeHierarchyFeature.dispose (http://localhost:3000/36.bundle.js:380:32)
    at http://localhost:3000/36.bundle.js:628:42
    at CallbackList.../../packages/core/lib/common/event.js.CallbackList.invoke (http://localhost:3000/bundle.js:100223:39)

Possible related: #3150, #3145. Something is odd with the reconnection in Java.

kittaakos · 2018-10-12T08:41:11Z

packages/typehierarchy/src/browser/tree/typehierarchy-tree-container.ts

+
+    child.unbind(TreeImpl);
+    child.bind(TypeHierarchyTree).toSelf();
+    child.rebind(Tree).toDynamicValue(ctx => ctx.container.get(TypeHierarchyTree));


TODO: #3153

toDynamicValue -> toService.

simark · 2018-10-12T14:50:09Z

Could you point me to the latest version of the LSP proposal for type hierarchy? I would like to test this with clangd, if I have the time.

kittaakos · 2018-10-12T19:33:57Z

latest version of the LSP proposal for type hierarchy

microsoft/vscode-languageserver-node#346

Note, this implementation differs from the proposed one.

Extracted from the source:

Client capabilities
Server capabilities
Language features
- textDocument/subTypes
- textDocument/superTypes
Added optional uri?: string field to the DocumentSymbol.

Or in Java/Xtend: eclipse-lsp4j/lsp4j#273

packages/languages/src/browser/typehierarchy/typehierarchy-feature.ts

kittaakos · 2018-10-15T12:21:32Z

packages/typehierarchy/src/browser/typehierarchy-contribution.ts

+
+    registerMenus(menus: MenuModelRegistry): void {
+        super.registerMenus(menus);
+        const menuPath = [...EDITOR_CONTEXT_MENU, 'navigation'];


Should go into its own 'type-hierarchy' whatever menu group, instead of the 'navigation'

kittaakos · 2018-10-15T14:14:28Z

packages/typehierarchy/src/browser/tree/typehierarchy-tree-widget.tsx

+            return <div className={'symbol-icon ' + this.icons.get(node.kind) || 'unknown'}></div>;
+        }
+        // tslint:disable-next-line:no-null-keyword
+        return null;


Should be undefined. See: #3181

kittaakos · 2018-10-17T15:14:48Z

I have noticed another UX issue, we should not reveal the document symbol, when expanding the nodes in the type hierarchy tree.

Update:
This is a generic issue with the tree widgets without "multi-selection" support. We fire a selection change event when we expand the node. Perhaps, it is out of the context of this PR.

AlexTugarev · 2018-10-17T15:51:56Z

I have noticed another UX issue, we should not reveal the document symbol, when expanding the nodes in the type hierarchy tree.

I see the same behavior with the call hierarchy. And after a quick comparison to Rider, I tend to agree that this is an UX issue. Personally I'd expect to reveal the symbol on selection. Unfortunately, expansion is equal to selection in trees.

We fire a selection change event when we expand the node. Perhaps, it is out of the context of this PR.

... but an interesting topic.

simark · 2018-10-18T00:17:47Z

One thing to look out for: make sure this plays well with restarting language servers.

If you rebase on top of #3215, you can try restarting a language server (I tested with Java, so you should be able to reproduce with that). I get infinite recursion during dispose:

kittaakos · 2018-10-18T05:01:56Z

One thing to look out for: make sure this plays well with restarting language servers.

#3148 (comment)

If you rebase on top of #3215,

Why to rebased? The reconnecting issue happens from the master branch too: #3145 (comment)

simark · 2018-10-18T12:59:33Z

Oh sorry, I missed that comment. Well, it gives you a more straightforward way to reproduce :).

kittaakos · 2018-12-11T07:50:34Z

The PR: #3802.

kittaakos requested review from AlexTugarev and akosyakov October 11, 2018 13:25

kittaakos mentioned this pull request Oct 11, 2018

GH-28: Added support for the super- and subtype hierarchies. eclipse-jdtls/eclipse.jdt.ls#823

Closed

kittaakos mentioned this pull request Oct 11, 2018

[WIP] Proposal for type hierarchy microsoft/vscode-languageserver-node#346

Closed

kittaakos commented Oct 12, 2018

View reviewed changes

kittaakos mentioned this pull request Oct 15, 2018

Proposal of the type hierarchy protocol extension. microsoft/vscode-languageserver-node#426

Closed

kittaakos commented Oct 17, 2018

View reviewed changes

kittaakos force-pushed the GH-707 branch from f853a03 to 8bb8545 Compare October 17, 2018 15:33

This was referenced Oct 19, 2018

[callhierarchy] Add proposed LSP implementation #3220

Closed

Reconnecting issues #3224

Closed

[tree] Do not fire a selection change event when expanding/collapsing nodes in the tree #3225

Open

kittaakos closed this Nov 7, 2018

kittaakos force-pushed the GH-707 branch from 8bb8545 to 8c3be7c Compare November 7, 2018 19:03

kittaakos reopened this Nov 8, 2018

kittaakos closed this Nov 18, 2018

kittaakos force-pushed the GH-707 branch from 8bb8545 to 8c3be7c Compare November 18, 2018 15:45

kittaakos mentioned this pull request Dec 11, 2018

GH-707: Introduced the @theia/typehierarchy extension. #3802

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GH-707: Introduced the `@theia/typehierarchy` extension. #3148

GH-707: Introduced the `@theia/typehierarchy` extension. #3148

kittaakos commented Oct 11, 2018

AlexTugarev commented Oct 11, 2018

kittaakos commented Oct 11, 2018

kittaakos Oct 12, 2018

simark commented Oct 12, 2018

kittaakos commented Oct 12, 2018

kittaakos Oct 15, 2018

kittaakos Oct 15, 2018

kittaakos commented Oct 17, 2018 •

edited

Loading

AlexTugarev commented Oct 17, 2018

simark commented Oct 18, 2018

kittaakos commented Oct 18, 2018

simark commented Oct 18, 2018

kittaakos commented Dec 11, 2018

GH-707: Introduced the @theia/typehierarchy extension. #3148

GH-707: Introduced the @theia/typehierarchy extension. #3148

Conversation

kittaakos commented Oct 11, 2018

AlexTugarev commented Oct 11, 2018

kittaakos commented Oct 11, 2018

kittaakos Oct 12, 2018

Choose a reason for hiding this comment

simark commented Oct 12, 2018

kittaakos commented Oct 12, 2018

kittaakos Oct 15, 2018

Choose a reason for hiding this comment

kittaakos Oct 15, 2018

Choose a reason for hiding this comment

kittaakos commented Oct 17, 2018 • edited Loading

AlexTugarev commented Oct 17, 2018

simark commented Oct 18, 2018

kittaakos commented Oct 18, 2018

simark commented Oct 18, 2018

kittaakos commented Dec 11, 2018

GH-707: Introduced the `@theia/typehierarchy` extension. #3148

GH-707: Introduced the `@theia/typehierarchy` extension. #3148

kittaakos commented Oct 17, 2018 •

edited

Loading