Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel inference #108
base: develop
Are you sure you want to change the base?
Parallel inference #108
Changes from 17 commits
ce74e6e
936c60a
d870289
b39b796
b95e167
9fe691c
5f92574
71fdf0e
9264754
06a575d
fa89bb8
a6a4ea4
8a73f62
db560eb
b21d811
48ad37b
b9ecc14
1a0ae49
27965ff
43167c5
6974ac3
2016c7b
bd391f5
1cd4982
079036a
d6a77ff
b8be926
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here's one thing I wonder about in general -- say you have Anemoi inference inside a slurm job which happens to do other things as well, eg, run anemoi inference first, intended in non-dist mode, and then some postproc in parallel. That makes the SLURM_<...> variables visible to the anemoi code, but does not expect it to heed it. Wouldn't that cause misbehavior, as in, making anemoi inference thinking it is running in dist mode when it actually shouldn't be?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ftr, it's not a hypothetical question, I do exactly that in Cascade :) And we have two layers of the problem:
for the first one, it may be easiest to use custom env vars (ANEMOI_NODELIST, ANEMOI_JOBID, ...), and have the example bash submit script set them to slurm's vars. And for the second one... well, a more profound deliberation needs to be taken, but let's just keep it in mind laterally, and solve it later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good point
I am reticent to add more env vars. I think a 'num-gpus' entry to the anemoi-inference config, which defaults to 1, would suffice. But yeah more thought is needed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmi I believe the first point is resolved now that parallelism is disabled by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In training we seed the whole parallel model group with the same random seed I think it would be nice to do the same here as well. The challenge is to generate appropriate seeds...