Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for output_frequency to write less output #109

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

b8raoult
Copy link
Collaborator

Allow users to write only certain steps. The frequency can be set globally or per output.

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (e89974c) to head (39497f3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #109   +/-   ##
========================================
  Coverage    98.03%   98.03%           
========================================
  Files            3        3           
  Lines           51       51           
========================================
  Hits            50       50           
  Misses           1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


@abstractmethod
def write_step(self, state, step):
"""This method should be be called directly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""This method should be be called directly
"""This method should not be called directly

@dietervdb-meteo
Copy link
Contributor

dietervdb-meteo commented Jan 20, 2025

Should it be enforced/checked that output_frequency is a multiple of the model timestep? In the current implementation one can set up a 24h lead time inference, put output_frequency=4 or output_frequency=5 for a 6h step model and inference will run without problems. In the first case the actual output_frequency will be 12, the lcm, while in the second case no output will be generated since the lcm, 30, is outside of the lead time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Now In Progress
Development

Successfully merging this pull request may close these issues.

3 participants