Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add omegaconf dict and list as input to DotDict #61

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

JPXKQX
Copy link
Member

@JPXKQX JPXKQX commented Nov 27, 2024

This PR adds support to cast omegaconf.DictConfig and omegaconf.ListConfig to DotDict

@JPXKQX JPXKQX self-assigned this Nov 27, 2024
@JPXKQX JPXKQX added the no changelog Flag a PR as not requiring a changelog update label Nov 27, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (2837ecd) to head (89817e3).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #61   +/-   ##
========================================
  Coverage    71.86%   71.86%           
========================================
  Files            7        7           
  Lines          263      263           
========================================
  Hits           189      189           
  Misses          74       74           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmertes gmertes merged commit 5a7c196 into develop Dec 13, 2024
53 checks passed
@gmertes gmertes deleted the feature/cast-omega-dictconfig branch December 13, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Flag a PR as not requiring a changelog update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants