Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/ssl fix #12

Merged
merged 11 commits into from
Dec 20, 2023
Merged

Hotfix/ssl fix #12

merged 11 commits into from
Dec 20, 2023

Conversation

sametd
Copy link
Member

@sametd sametd commented Dec 20, 2023

With this pull request token support added for the kube-state-metrics connection. Also various refinements were introduced:

  • namespace were assumed to be aviso in the monitoring system, now namespace value is taken from the pods
  • token is taken from the config if available
  • opsview reporter is enhanced with ssl variables

As a note, with this commits, opsview is fully working again.

@sametd sametd requested a review from jameshawkes December 20, 2023 22:39
Copy link
Contributor

@jameshawkes jameshawkes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merge when checks have finished

@sametd sametd merged commit c0d0f2b into develop Dec 20, 2023
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants