Merge pull request #941 from weichou1229/issue-4989

fix: Allow binary reading value to be empty
edgexfoundry · Nov 8, 2024 · a873294 · a873294
2 parents bbedcee + d524d8c
commit a873294
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/dtos/reading.go b/dtos/reading.go
@@ -41,7 +41,7 @@ type SimpleReading struct {
 }
 
 type BinaryReading struct {
-	BinaryValue []byte `json:"binaryValue,omitempty" validate:"omitempty,gt=0"`
+	BinaryValue []byte `json:"binaryValue,omitempty" validate:"omitempty"`
 	MediaType   string `json:"mediaType,omitempty" validate:"required_with=BinaryValue"`
 }
 

diff --git a/dtos/requests/event_test.go b/dtos/requests/event_test.go
@@ -120,7 +120,7 @@ func TestAddEventRequest_Validate(t *testing.T) {
 		{"invalid AddEventRequest, no Reading ValueType", invalidReadingNoValueType, true},
 		{"invalid AddEventRequest, invalid Reading ValueType", invalidReadingInvalidValueType, true},
 		{"invalid AddEventRequest, no SimpleReading Value", invalidSimpleReadingNoValue, true},
-		{"invalid AddEventRequest, no BinaryReading BinaryValue", invalidBinaryReadingNoValue, true},
+		{"valid AddEventRequest, no BinaryReading BinaryValue", invalidBinaryReadingNoValue, false},
 		{"invalid AddEventRequest, no BinaryReading MediaType", invalidBinaryReadingNoMedia, true},
 		{"valid AddEventRequest, nil Binary value", nilBinaryReadingNoMedia, false},
 		{"valid AddEventRequest, nil Simple value", nilSimpleReading, false},