Copy structs when they exist

[harrisi]

Fixes #65 (and I think #55, and partially #28 maybe?).

I'm not sure if this is the proper fix, or if the test is ideal. Happy to modify things if needed.

[edgurgel]

Thank you! I will do some testing and release a new version cheers!

[harrisi]

I figure I should mention, I'm not copying which fields are required or not, so there's no way to test construction of a struct is done with required fields. That didn't seem like something anyone has opened an issue about, so I left it out of this PR.

It would maybe make sense to do that, but I don't actually use Mimic so I'm not sure if that's outside the scope of this package.

[edgurgel]

It would maybe make sense to do that, but I don't actually use Mimic so I'm not sure if that's outside the scope of this package.

Yeah I'm not too sure if the required keys is needed at the time that Mimic runs. It might be worth doing just in case someone is relying on getting the metadata about structs and expect to see the same info with and without Mimic I guess 🤷

[edgurgel]

In any case this should do the job: 816fd77

[jimsynz]

This caused some intermittent test failures for me where dynamically creating a struct with Kernel.struct/2 from a copied module. In my case the copied module only had a single assertion against it so I was able to remove it. I couldn't figure out how to reproduce it, otherwise I'd open a PR so I'm leaving a comment here in case other folks hit it.

Related commit is ash-project/reactor@e4d73d3

[edgurgel]

Thanks, @jimsynz that's very useful! 🤔