Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get correct service tags for nginx logs in EC2 #893

Open
timmc-edx opened this issue Jan 13, 2025 · 1 comment
Open

Get correct service tags for nginx logs in EC2 #893

timmc-edx opened this issue Jan 13, 2025 · 1 comment

Comments

@timmc-edx
Copy link
Member

timmc-edx commented Jan 13, 2025

nginx logs for our remaining EC2 services (edxapp, insights, etc.) are getting tagged in Datadog with service:edx-nginx rather than the relevant service. This is making it harder to find logs and to sort out which logs go with which service.

Notes:

  • Logs are actually getting double tagged, e.g. service:edx-edxapp-lms, service:edx-nginx -- the latter appears to override the former.
  • The unwanted tag is coming from a common datadog config block for the entire environment that is explicitly tagging all nginx logs as service:edx-nginx: https://github.com/edx/edx-internal/blob/ec0fc544b3eca361c7d2e25fa0d4be9f4ba3b60d/ansible/vars/prod-edx.yml#L187
    • Can we just remove that service attribute?
    • If not, file a Datadog support ticket asking how this is supposed to work. (It doesn't seem to make sense that you'd have to explicitly tag log sources when there's also a host-level tag available.)
  • If this turns out to be too much work, we can just document it and let people know about the problem, and hope it doesn't cause too much trouble in the time before everything is containerized.
@timmc-edx timmc-edx converted this from a draft issue Jan 13, 2025
@robrap robrap moved this to Backlog in Arch-BOM Jan 14, 2025
@timmc-edx
Copy link
Member Author

@nadeemshahzad Do you know if it's possible for us to remove the service: edx-nginx from this config? It's overriding and conflicting with the host service tags. I vaguely recall that there was some issue with removing the log-level service tag but I don't recall what it was.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant