fix: set session sample rate configurable and defaults to 0 #29
Conversation
src/DatadogLoggingService.js
Outdated
| @@ -35,8 +35,8 @@ class DatadogLoggingService extends NewRelicLoggingService { | |||
| service: process.env.DATADOG_SERVICE, | |||
| env: process.env.DATADOG_ENV, | |||
| version: process.env.DATADOG_VERSION, | |||
| sessionSampleRate: 50, | |||
| sessionReplaySampleRate: 100, | |||
| sessionSampleRate: parseInt(process.env.SESSION_SAMPLE_RATE || 0, 10), | |||
There was a problem hiding this comment.
Should the 0 be the default? Should that be 50?
There was a problem hiding this comment.
do we want sessionSampleRate default to 50 for all MFEs? if yes then i'll update it
src/DatadogLoggingService.js
Outdated
| sessionSampleRate: 50, | ||
| sessionReplaySampleRate: 100, | ||
| sessionSampleRate: parseInt(process.env.SESSION_SAMPLE_RATE || 0, 10), | ||
| sessionReplaySampleRate: parseInt(process.env.SESSION_REPLAY_SAMPLE_RATE || 0, 10), |
There was a problem hiding this comment.
0 default seems right for this for now. Should we add a comment that we are defaulting to 0 until we work out privacy concerns?
src/DatadogLoggingService.js
Outdated
| @@ -47,7 +47,7 @@ class DatadogLoggingService extends NewRelicLoggingService { | |||
| site: process.env.DATADOG_SITE, | |||
| env: process.env.DATADOG_ENV, | |||
| forwardErrorsToLogs: true, | |||
| sessionSampleRate: 100, | |||
| sessionSampleRate: parseInt(process.env.SESSION_SAMPLE_RATE || 0, 10), | |||
There was a problem hiding this comment.
Do we want 100 as our default for now?
There was a problem hiding this comment.
i was thinking to default everything to 0 and then configure from envs. but if we want default values set, i'll update it
There was a problem hiding this comment.
should sessionSampleRate for both RUM and Browser logging differ?
i am currently using same env for both
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #29 +/- ##
=========================================
Coverage ? 95.83%
=========================================
Files ? 1
Lines ? 48
Branches ? 17
=========================================
Hits ? 46
Misses ? 2
Partials ? 0 ☔ View full report in Codecov by Sentry. |
No description provided.