fix: updates defaultPrivacyLevel to "mask" in DatadogLoggingService
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamstankiewicz
commented
Aug 16, 2024
| @@ -67,7 +67,8 @@ class DatadogLoggingService extends NewRelicLoggingService { | |||
| trackUserInteractions: true, | |||
| trackResources: true, | |||
| trackLongTasks: true, | |||
| defaultPrivacyLevel: process.env.DATADOG_PRIVACY_LEVEL || 'mask-user-input', | |||
| defaultPrivacyLevel: process.env.DATADOG_PRIVACY_LEVEL || 'mask', | |||
| enablePrivacyForActionName: process.env.DATADOG_ENABLE_PRIVACY_FOR_ACTION_NAME || true, | |||
There was a problem hiding this comment.
Also added enablePrivacyForActionName: true here, similar to the changes from this PR: https://github.com/edx/edx-internal/pull/11415
robrap
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the 2U privacy/legal teams are evaluating the session replay privacy concerns/implications across all vendors, we want to change
DatadogLoggingService's basedefaultPrivacyLeveltomask, ensuring all content is masked within session replays, if enabled, by default. Currently, only user input is masked.This will not preclude an application from overriding it, if needed via a configured environment variable. Similarly, the updated
defaultPrivacyLevel: "mask"will properly interact with the Datadog HTML attributes / class names to mask/unmask specific UI elements / components (e.g., see openedx/frontend-platform#723).