Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: draw isosub over the design #583

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

feat: draw isosub over the design #583

wants to merge 3 commits into from

Conversation

kareefardi
Copy link
Collaborator

Steps

  • Magic.AddIsosub:
    • New step to draw isosub over the design bounding box.
  • Magic.StreamOut:
    • Added MAGIC_ADD_ISOSUB to enable drawing isosub over the design bounding box.
  • KLayout.StreamOut:
    • Added KLAYOUT_ADD_ISOSUB to enable drawing isosub over the design bounding box.
    • Added ISOSUB_LAYER, a pdk variable, specifying the layer/datatype pairing for isosub layer.

Resolves #531

Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
@kareefardi
Copy link
Collaborator Author

@donn Thought on the name "isosub"?

@kareefardi kareefardi requested a review from donn October 16, 2024 12:21
@openlane-bot
Copy link
Collaborator

openlane-bot commented Oct 16, 2024

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • ‼️ Results for sky130A/sky130_fd_sc_hd/wbqspiflash appear to be missing!
  • No changes to critical metrics were detected in analyzed designs.

Full tables ► https://gist.github.com/openlane-bot/ef8acd0003d3a5a1d95b2d160a109004

Copy link
Member

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some minor adjustments needed

openlane/steps/magic.py Outdated Show resolved Hide resolved
openlane/steps/magic.py Show resolved Hide resolved
openlane/config/pdk_compat.py Show resolved Hide resolved
openlane/steps/klayout.py Outdated Show resolved Hide resolved
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants