feat!: quit on hold violations on all corners #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Metric comparisons are in beta. Please report bugs under the issues tab.
Full tables ► https://gist.github.com/openlane-bot/94cd8212fa4ef9a192cebc5b4bd15e63 |
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
kareefardi
changed the title
This reverts commit 7c0a979.
|
While you're here, tt needs to be taken from the PDK instead of being set as part of the variable name. This already caused an issue or two with some of our internal PDKs. |
donn
added
the
💬 waiting on op
kareefardi
removed
the
💬 waiting on op
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
donn
reviewed
Jan 6, 2025
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
Signed-off-by: Kareem Farid <kareefardi@users.noreply.github.com>
donn
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes hold violations to raise an error on any corner, not just typical corners.
Resolves #523