Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add CI and Task for formatting R and Rust code #73

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

etiennebacher
Copy link
Contributor

@etiennebacher etiennebacher commented Jan 23, 2025

Fixes #72

Putting this in draft until a few issues and features are complete in air, specifically:

tibble::tribble(
  ~.test_name, ~object,
  "Int8", pl$Int8,
  "Int16", pl$Int16,
  "Int32", pl$Int32,
  "Int64", pl$Int64,
  "UInt8", pl$UInt8,
)

becomes:

tibble::tribble(
  ~.test_name,
  ~object,
  "Int8",
  pl$Int8,
  "Int16",
  pl$Int16,
  "Int32",
  pl$Int32,
  "Int64",
  pl$Int64,
  "UInt8",
  pl$UInt8,
)

When those are fixed, I'll make a separate PR where I actually run the formatters so that this PR is not drowned in formatting changes.

install-air:
desc: Install Air to format R code.
cmds:
- curl -LsSf https://github.com/posit-dev/air/releases/latest/download/air-installer.sh | sh
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is downloaded every time task fmt runs, which is bad. @eitsupi do you know why this is executed while other setup tasks are skipped? Is it because this is a curl command and there's no way to know if it's outdated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI and task for formatting
1 participant