Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make unknown_devices.attributes.leased a dict #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

illuzn
Copy link

@illuzn illuzn commented Jul 5, 2024

This makes each item in unknown_devices.attributes.leased a dict (i.e. a dict of dicts).

For example

leased:
  192.168.1.2:
    mac: aa:bb:cc:dd:ee:ff
    hostname: abcdef
  192.168.1.3:
    mac: 11:22:33:44:55:66
    hostname: 123456

This makes processing this attribute far easier in Home Assistant for example in my unknown devices blueprint which generates a notification when an unknown device connects.

Technically, this is a breaking change but it the behaviour was broken by an undocumented change during the refactor anyway - from 192.168.1.2: aa:bb:cc:dd:ee:ff (?) to 192.168.1.2: aa:bb:cc:dd:ee:ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant