Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Lucene 10.1.0 #119308

Open
wants to merge 756 commits into
base: main
Choose a base branch
from
Open

Upgrade to Lucene 10.1.0 #119308

wants to merge 756 commits into from

Conversation

ChrisHegarty
Copy link
Contributor

This commit upgrades to Lucene 10.1.0.

cbuescher and others added 30 commits October 2, 2024 14:06
The 'persian' analyzer for Lucene 10 comes with PersianStemFilter as the last
token filter by default. In order to maintain compatibility for old indices, we 
use the new analyzer for new indices but configure a legacy analyzer that is
used with existing indices.
The 'romanian' language analyzer has been improved in Lucene 10 in two important
ways. First, the snowball stemmer has been modified to work with s-comma and t-comma characters
but only with their cedilla forms used when Romanian didn't have full Unicode
support (snowballstem/snowball#177). Second, the
analyzer now contains a normalization step to map cedilla forms to forms with comma.

In order to maintain backwards compatibility with existing indices, this change
moves the Lucene 9 stemmer over to the analysis module was a deprecated variant
and creates the analyzer for existing indices with the "old" stemmer and without
the normalization step. New indices automatically run with the improved
behaviour.
This was restored due to a bad merge.
@elasticsearchmachine elasticsearchmachine added the serverless-linked Added by automation, don't add manually label Dec 29, 2024
@ChrisHegarty ChrisHegarty added test-full-bwc Trigger full BWC version matrix tests test-release Trigger CI checks against release build test-update-serverless labels Dec 29, 2024
@ChrisHegarty ChrisHegarty requested a review from javanna December 30, 2024 11:25
@ChrisHegarty ChrisHegarty requested a review from tlrx January 2, 2025 10:10
@ChrisHegarty ChrisHegarty removed the test-release Trigger CI checks against release build label Jan 2, 2025
@ChrisHegarty ChrisHegarty added the test-release Trigger CI checks against release build label Jan 3, 2025
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks (only one small thing in the buildkite pipelines that I think should get reverted, although it should not take effect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Search/Search Search-related issues that do not fall into other categories serverless-linked Added by automation, don't add manually Team:Search Meta label for search team test-full-bwc Trigger full BWC version matrix tests test-release Trigger CI checks against release build test-update-serverless >upgrade v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants