[8.x] Add Hdfs patcher to replace deprecated Subject method #119781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldematte
added
>non-issue
:Core/Infra/Core
ldematte
commented
Jan 8, 2025
| mv.visitJumpInsn(GOTO, end); | ||
| mv.visitLabel(olderJdk); | ||
| super.visitMethodInsn(opcode, owner, name, descriptor, isInterface); | ||
| mv.visitLabel(end); |
There was a problem hiding this comment.
When decompiled, Intellij shows this whole thing as
Subject subject = Runtime.version().feature() > 17 ? Subject.current() : Subject.getSubject(context);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119779
This backport is slightly more complex than the original on main, as
Subject#currenthas been introduced with Java 18, and 8.x could still run on Java 17. Therefore, we need to check the runtime version to see if we can invoke it.Tested by using:
with both
-Druntime.java=17and-Druntime.java=23