Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing AwaitsFix annotation for fixed DataStreamsUpgradeIT test #119809

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Jan 8, 2025

DataStreamsUpgradeIT. testUpgradeDataStream was fixed in #119786, I missed that an AwaitsFix annotation had been added. This removes that now that the test is fixed.

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Data Management/Data streams Data streams and their lifecycles auto-backport Automatically create backport pull requests when merged v9.0.0 v8.18.0 labels Jan 8, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jan 8, 2025
Copy link
Contributor

@parkertimmins parkertimmins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@masseyke masseyke merged commit 55da522 into elastic:main Jan 9, 2025
16 checks passed
@masseyke masseyke deleted the remove-awaitsfix-119713 branch January 9, 2025 13:28
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 119809

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Data Management/Data streams Data streams and their lifecycles Team:Data Management Meta label for data/management team >test Issues or PRs that are addressing/adding tests v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants