Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to the full 40 character GPG fingerprint for apt keys #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sjahl
Copy link

@sjahl sjahl commented Jun 3, 2015

This commit replaces the 8-character apt key value with the full 40 character one (I noticed this was producing a warning when used with puppetlabs-apt 1.8.0 and puppet 3.8.1). I saw other references to the short GPG fingerprint for Suse, but left them as-is, since I think the long key is really only required for puppetlabs-apt.

This should fix #36

@sjahl
Copy link
Author

sjahl commented Jun 3, 2015

Oops, didn't realize I had to sign a CLA. I just signed it now :)

@electrical
Copy link

Can one of the admins verify this patch?

@jonhattan
Copy link

Test fails seems completely unrelated.

Fetching git@github.com:puppetlabs/beaker.git
Warning: Permanently added the RSA host key for IP address '192.30.252.131' to the list of known hosts.
Permission denied (publickey).
fatal: Could not read from remote repository.

oloc pushed a commit to oloc/puppet-logstashforwarder that referenced this pull request Jul 20, 2015
@elasticsearch-release
Copy link

Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'.

@oloc
Copy link

oloc commented Jul 21, 2015

You need to modify the Gemfile and some .travis.yml to pass the tests.
I suggest you to have a look to my PR #60 .

@sjahl
Copy link
Author

sjahl commented Jul 27, 2015

If #60 gets merged, I'm happy to rebase this patch on it.

@elasticsearch-release
Copy link

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 character apt key in repo.pp
5 participants