-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use core Node.js resolve function if possible #25
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, as far as I can tell.
Can we revisit this PR? We've got reports that this impacts performance by around 30% |
This was never merged because I never put in the time to get confident in it not breaking under certain circumstances (as mentioned in the PR description). I think my main concern was the feature detection logic. I see two roads forward right now:
|
It looks like this PR fails the tests for Node 8, 10, 12 and 14 but they pass for Node 16 onwards. I'll try and work out why! |
I'm actually a little unsure about if this actually works 100% as expected. But if it does, I think this is a good improvement. See browserify/resolve#188 for details.
So I'm a bit hesitant to merge this until we know for sure.