fix: update @electron/asar to 3.2.18 to resolve signing issue with fr…

…amework symlinks (#8762) fixes: #8655
electron-userland · Jan 8, 2025 · c4f5497 · c4f5497
1 parent 5c44725
commit c4f5497
Show file tree

Hide file tree

Showing 4 changed files with 26 additions and 7 deletions.
diff --git a/.changeset/cuddly-colts-laugh.md b/.changeset/cuddly-colts-laugh.md
@@ -0,0 +1,5 @@
+---
+"app-builder-lib": patch
+---
+
+fix: update @electron/asar to 3.2.18 to resolve signing issue with framework symlinks
diff --git a/packages/app-builder-lib/package.json b/packages/app-builder-lib/package.json
@@ -48,7 +48,7 @@
   "dependencies": {
     "@develar/schema-utils": "~2.6.5",
     "@electron/fuses": "^1.8.0",
-    "@electron/asar": "3.2.17",
+    "@electron/asar": "3.2.18",
     "@electron/notarize": "2.5.0",
     "@electron/osx-sign": "1.3.1",
     "@electron/rebuild": "3.7.0",

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test/snapshots/globTest.js.snap b/test/snapshots/globTest.js.snap
@@ -9906,15 +9906,19 @@ exports[`symlinks everywhere w/ static framework 3`] = `
                       "files": {
                         "Headers": {
                           "link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/Current/Headers",
+                          "unpacked": true,
                         },
                         "Hello": {
                           "link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/Current/Hello",
+                          "unpacked": true,
                         },
                         "Info.plist": {
                           "link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/Current/Info.plist",
+                          "unpacked": true,
                         },
                         "Modules": {
                           "link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/Current/Modules",
+                          "unpacked": true,
                         },
                         "Versions": {
                           "files": {
@@ -9992,6 +9996,7 @@ exports[`symlinks everywhere w/ static framework 3`] = `
                             },
                             "Current": {
                               "link": "node_modules/hello-world/lib/Release/Hello.framework/Versions/A",
+                              "unpacked": true,
                             },
                           },
                           "unpacked": true,
@@ -10049,6 +10054,11 @@ exports[`symlinks everywhere w/ static framework 4`] = `
   ",
     "name": "app.asar.unpacked/node_modules/hello-world/package.json",
   },
+  "app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Headers",
+  "app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Hello",
+  "app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Info.plist",
+  "app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Modules",
+  "app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Versions/Current",
   "app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Versions/A/Hello",
   "app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Versions/A/Info.plist",
   "app.asar.unpacked/node_modules/hello-world/lib/Release/Hello.framework/Versions/A/Modules/Hello.abi.json",
@@ -10078,6 +10088,7 @@ exports[`unpackDir 2`] = `
       "files": {
         "file-symlink2": {
           "link": "assets/file2",
+          "unpacked": true,
         },
         "file1": {
           "size": 4,
@@ -10091,6 +10102,7 @@ exports[`unpackDir 2`] = `
           "files": {
             "file-symlink1": {
               "link": "assets/file1",
+              "unpacked": true,
             },
             "file3": {
               "size": 4,
@@ -10192,6 +10204,7 @@ exports[`unpackDir one 2`] = `
       "files": {
         "file-symlink2": {
           "link": "assets/file2",
+          "unpacked": true,
         },
         "file1": {
           "size": 4,
@@ -10205,6 +10218,7 @@ exports[`unpackDir one 2`] = `
           "files": {
             "file-symlink1": {
               "link": "assets/file1",
+              "unpacked": true,
             },
             "file3": {
               "size": 4,