Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More clearly separate the two different types of themes in theming.md #16096

Open
aaronraimist opened this issue Jan 9, 2021 · 5 comments
Open

More clearly separate the two different types of themes in theming.md #16096

aaronraimist opened this issue Jan 9, 2021 · 5 comments
Labels
A-Documentation A-Theming T-Enhancement

Comments

@aaronraimist
Copy link
Collaborator

No description provided.

@jryans
Copy link
Collaborator

jryans commented Jan 22, 2021

Seems like a good idea 😄

@Ashray123
Copy link

I would like to work on this issue, any guide on how to do it will be great :)

@aaronraimist
Copy link
Collaborator Author

@Ashray123 Basically just split up https://github.com/vector-im/element-web/blob/develop/docs/theming.md. I think it would probably make more sense to have CSS themes and JSON based themes described in two separate files. But maybe they should stay in one file and the two different sections should just be renamed to be more clear about what each section is talking about.

This was referenced Mar 27, 2021
Closed
Closed
Ashray123 added a commit to Ashray123/element-web that referenced this issue Mar 28, 2021
@Ashray123
Modifying the theming.md file for better understanding
8539ff1 
Split the css and JSON based themes to provide clear understanding of the themes.

Fixes: element-hq#16096

Signed-off-by: ASHRAY <jha.ashray12@gmail.com>
@Ashray123 Ashray123 mentioned this issue Mar 28, 2021
Closed
@Ashray123
Copy link

Hey @aaronraimist due to some issues with my local git I was unable to make changes in the existing branch. Made a new patch for the changes. If you could review the recent one it would be awesome. 😁

@SimonBrandner SimonBrandner removed the Help Wanted Extra attention is needed label Aug 27, 2021
@t3chguy
Copy link
Member

t3chguy commented Jul 13, 2023

Related #16804

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Documentation A-Theming T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modifying the theming.md file for better understanding Ashray123/element-web
5 participants
@jryans @t3chguy @aaronraimist @SimonBrandner @Ashray123