Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying the theming.md file for better understanding #16806

Closed
wants to merge 5 commits into from

Conversation

Ashray123
Copy link

Split the css and JSON based themes to provide clear understanding of the themes.

Fixes: #16096

Signed-off-by: ASHRAY jha.ashray12@gmail.com

Split the css and JSON based themes to provide clear understanding of the themes.

Fixes: element-hq#16096

Signed-off-by: ASHRAY <jha.ashray12@gmail.com>
Copy link
Collaborator

@aaronraimist aaronraimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

I'm not on the team though, you'll still need to wait for review from them.

docs/theming.md Outdated Show resolved Hide resolved
Co-authored-by: Aaron Raimist <aaron@raim.ist>
docs/theming.md Outdated Show resolved Hide resolved
docs/theming.md Outdated Show resolved Hide resolved
docs/theming.md Outdated Show resolved Hide resolved
@aaronraimist aaronraimist added the Z-Community-PR Issue is solved by a community member's PR label Apr 18, 2021
@Ashray123 Ashray123 requested a review from t3chguy April 29, 2021 09:07
@SimonBrandner SimonBrandner removed the Z-Community-PR Issue is solved by a community member's PR label Aug 27, 2021
@t3chguy t3chguy removed their request for review April 27, 2023 10:19
@Johennes
Copy link
Contributor

Closing since this hasn't seen any actions in two years and theming is going to change with Compound.

@Johennes Johennes closed this Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More clearly separate the two different types of themes in theming.md
5 participants