Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and stabilise sliding sync playwright tests #28809

Merged
merged 8 commits into from
Jan 2, 2025
Merged

Fix and stabilise sliding sync playwright tests #28809

merged 8 commits into from
Jan 2, 2025

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Dec 23, 2024 •
edited
Loading

Fixes #27459

  • Moves the sliding proxy fixture into the tests which use it, especially as proxy support is on its way out.
  • Makes Network offline/online stuff opt-in rather than automagic as it caused issues with sliding sync routing
  • Wire up sliding sync routing, without this the tests never would have worked
  • Ensure we load the page after adding the sliding sync init script, otherwise we'll be using legacy sync

@t3chguy
Fix and stabilise sliding sync playwright tests
63ce698 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy added the T-Task Tasks for the team like planning label Dec 23, 2024
@t3chguy t3chguy self-assigned this Dec 23, 2024
@t3chguy
Iterate
7c9984c 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Revert test enablement
2185880 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy added 2 commits January 2, 2025 13:47
@t3chguy
Merge branch 'develop' of https://github.com/vector-im/element-web in…
058b5fa 
…to t3chguy/fix-sliding-sync-playwright
@t3chguy
Iterate
78c3a34 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Debug
d7ffffe 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
t3chguy added 2 commits January 2, 2025 15:33
@t3chguy
Iterate
8f0f5f0 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Unskip now fixed tests
572de04 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy marked this pull request as ready for review January 2, 2025 15:53
@t3chguy t3chguy requested a review from a team as a code owner January 2, 2025 15:53
@t3chguy t3chguy requested a review from dbkr January 2, 2025 15:53
@t3chguy t3chguy added this pull request to the merge queue Jan 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2025
@t3chguy t3chguy added this pull request to the merge queue Jan 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2025
@t3chguy t3chguy added this pull request to the merge queue Jan 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 2, 2025
@t3chguy t3chguy added this pull request to the merge queue Jan 2, 2025
Merged via the queue into develop with commit bd3e93e Jan 2, 2025
42 checks passed
@t3chguy t3chguy deleted the t3chguy/fix-sliding-sync-playwright branch January 2, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

Assignees

@t3chguy t3chguy

Labels
T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
2 participants
@t3chguy @dbkr