Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShareDialog: add share on Bluesky button #28885

Closed
wants to merge 1 commit into from
Closed

ShareDialog: add share on Bluesky button #28885

wants to merge 1 commit into from

Conversation

ethancedwards8
Copy link

@ethancedwards8 ethancedwards8 commented Jan 7, 2025 •
edited
Loading

This adds a button to share a user's matrix.to link on the Bluesky platform.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@ethancedwards8
ShareDialog: add share on Bluesky button
de3e4dc 
This adds a button to share a user's matrix.to link on the Bluesky
platform.

Signed-off-by: Ethan Carter Edwards <ethan@ethancedwards.com>
@ethancedwards8 ethancedwards8 requested a review from a team as a code owner January 7, 2025 01:15
@CLAassistant
Copy link

CLAassistant commented Jan 7, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 7, 2025
@MidhunSureshR MidhunSureshR added the X-Needs-Product More input needed from the Product team label Jan 7, 2025
MidhunSureshR
MidhunSureshR requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the jest snapshots and playwright screenshots.

@ethancedwards8
Copy link
Author

You need to update the jest snapshots and playwright screenshots.

I have no idea how to do either of those things.

@ethancedwards8
Copy link
Author

Hello @MidhunSureshR how may I revoke my signed CLA?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MidhunSureshR MidhunSureshR MidhunSureshR requested changes

@dbkr dbkr Awaiting requested review from dbkr dbkr is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement X-Needs-Design X-Needs-Product More input needed from the Product team Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ethancedwards8 @CLAassistant @MidhunSureshR