Very early WIP of rejigged e2e error toast code #28946
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianduros
force-pushed
the
florianduros/encryption-tab
branch
from
380ef62 to
8bd5d6a
Compare
dbkr
commented
Jan 9, 2025
Comment on lines
-341
to
-347
| it("checks key backup status when when account has cross signing", async () => { | ||
| mockCrypto!.getCrossSigningKeyId.mockResolvedValue(null); | ||
| mockCrypto!.userHasCrossSigningKeys.mockResolvedValue(true); | ||
| await createAndStart(); | ||
|
|
||
| expect(mockCrypto!.getActiveSessionBackupVersion).toHaveBeenCalled(); | ||
| }); |
There was a problem hiding this comment.
It's not clear why this test was testing this... I don't really understand why it would be important that it did this. Maybe in some circumstances it should, but if so shouldn't we be testing to see if it prompts you to set up key backup or whatever w're expecting?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.