apply clang-tidy include cleaner

eliogovea · Mar 8, 2024 · fe3254a · fe3254a
1 parent 0f14f3f
commit fe3254a
Show file tree

Hide file tree

Showing 12 changed files with 60 additions and 40 deletions.
diff --git a/.github/workflows/cmake.yml b/.github/workflows/cmake.yml
@@ -2,13 +2,9 @@ name: CMake
 
 on:
   push:
-    branches: [ "main", "dev" ]
+    branches: ["main", "dev"]
   pull_request:
-    branches: [ "main" ]
-
-env:
-  # Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)
-  BUILD_TYPE: Release
+    branches: ["main"]
 
 jobs:
   build:
@@ -18,28 +14,10 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v3
-
-    - name: Install dependencies
-      run: sudo apt install libgtest-dev
-
-    - name: Configure CMake
-      # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
-      # See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
-      run: |
-        cmake \
-          -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} \
-          --toolchain cmake/toolchain/gcc.cmake \
-          -S ${{github.workspace}} \
-          -B ${{github.workspace}}/build \
-
-    - name: Build
-      # Build your program with the given configuration
-      run: cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
+      - uses: actions/checkout@v3
 
-    - name: Test
-      working-directory: ${{github.workspace}}/build
-      # Execute tests defined by the CMake configuration.
-      # See https://cmake.org/cmake/help/latest/manual/ctest.1.html for more detail
-      run: ctest -C ${{env.BUILD_TYPE}} --extra-verbose
+      - name: Install dependencies
+        run: sudo apt install libgtest-dev
 
+      - name: make-clang-debug
+        run: cmake --workflow --preset make-clang-debug
diff --git a/CMakePresets.json b/CMakePresets.json
@@ -10,7 +10,6 @@
       "name": "make-base",
       "generator": "Unix Makefiles",
       "cacheVariables": {
-        "CMAKE_CXX_COMPILER_LAUNCHER": "ccache",
         "CMAKE_EXPORT_COMPILE_COMMANDS": true,
         "DNS_ENABLE_FORMATTING": true
       },

diff --git a/sources/dns_decode.cpp b/sources/dns_decode.cpp
@@ -1,11 +1,16 @@
 #include "dns_decode.hpp"
 
-#include <arpa/inet.h>
+#include <netinet/in.h>
 
+#include <cstdint>
 #include <cstring>
 #include <optional>
+#include <span>
+#include <vector>
 
+#include "dns.hpp"
 #include "dns_name.hpp"
+#include "dns_record.hpp"
 
 namespace DNS {
 auto Decode(std::uint8_t const* msg_ptr,

diff --git a/sources/dns_decode_fuzzer.cpp b/sources/dns_decode_fuzzer.cpp
@@ -1,7 +1,7 @@
-#include <iterator>
-#include <utility>
-#include <vector>
+#include <cstddef>
+#include <cstdint>
 
+#include "dns.hpp"
 #include "dns_decode.hpp"
 
 extern "C" int LLVMFuzzerTestOneInput(uint8_t const* data, size_t size)

diff --git a/sources/dns_decode_test.cpp b/sources/dns_decode_test.cpp
@@ -1,6 +1,12 @@
+#include <cstdint>
+#include <vector>
+
 #include <gtest/gtest.h>
 
+#include "dns.hpp"
 #include "dns_decode.hpp"
+#include "dns_name.hpp"
+#include "dns_record.hpp"
 
 TEST(dns_decoder, decode_16_bits_integer)
 {

diff --git a/sources/dns_encode.cpp b/sources/dns_encode.cpp
@@ -1,9 +1,16 @@
 #include "dns_encode.hpp"
 
-#include <arpa/inet.h>
+#include <netinet/in.h>
 
+#include <cstdint>
 #include <cstring>
+#include <iterator>
 #include <numeric>
+#include <span>
+
+#include "dns.hpp"
+#include "dns_name.hpp"
+#include "dns_record.hpp"
 
 namespace DNS {
 Header MakeHeader(Message const& message)

diff --git a/sources/dns_encode_test.cpp b/sources/dns_encode_test.cpp
@@ -1,5 +1,12 @@
+#include <cstdint>
+#include <iterator>
+#include <vector>
+
 #include <gtest/gtest.h>
 
+#include "dns.hpp"
+#include "dns_record.hpp"
+
 #include "dns_encode.hpp"
 
 TEST(dns_encoder, encode_record)

diff --git a/sources/dns_name.cpp b/sources/dns_name.cpp
@@ -1,6 +1,12 @@
 #include "dns_name.hpp"
 
 #include <algorithm>
+#include <cstddef>
+#include <cstdint>
+#include <iterator>
+#include <span>
+#include <string>
+#include <variant>
 
 namespace DNS {
 auto ToNameView(Name const& name) -> NameView

diff --git a/sources/dns_name_fuzzer.cpp b/sources/dns_name_fuzzer.cpp
@@ -1,5 +1,6 @@
-#include <iterator>
-#include <utility>
+#include <cstddef>
+#include <cstdint>
+#include <span>
 #include <vector>
 
 #include "dns_name.hpp"

diff --git a/sources/dns_name_test.cpp b/sources/dns_name_test.cpp
@@ -1,3 +1,9 @@
+#include <array>
+#include <cstddef>
+#include <cstdint>
+#include <string>
+#include <vector>
+
 #include <gtest/gtest.h>
 
 #include "dns_name.hpp"

diff --git a/sources/dns_record.cpp b/sources/dns_record.cpp
@@ -1,5 +1,7 @@
 #include "dns_record.hpp"
 
+#include <variant>
+
 namespace DNS {
 auto ToRecordDataView(RecordData const& data) -> RecordDataView
 {

diff --git a/sources/dns_resolver_testapp.cpp b/sources/dns_resolver_testapp.cpp
@@ -1,17 +1,20 @@
-#include <linux/socket.h>
 
-#include <arpa/inet.h>
+#include <netinet/in.h>
+#include <sys/socket.h>
 
 #include <array>
 #include <cstdint>
 #include <cstdlib>
-#include <format>
 #include <iomanip>
 #include <iostream>
+#include <span>
+#include <vector>
 
 #include "dns.hpp"
 #include "dns_decode.hpp"
 #include "dns_encode.hpp"
+#include "dns_name.hpp"
+#include "dns_record.hpp"
 
 void HexDump(std::ostream& output, std::span<std::uint8_t const> const& data)
 {