-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor repository structure #152
Comments
The current file str .
├── charts
│ └── tesk/
├── cloudbuild_testing.yaml
├── cloudbuild.yaml
├── containers
│ ├── filer.Dockerfile
│ └── taskmaster.Dockerfile
├── coverage.xml
├── doc
│ └── taskmaster_architecture.png
├── dockerBuild -> scripts//dockerBuild
├── dockerRun -> scripts//dockerRun
├── documentation/
├── examples/
├── init
├── install
├── LICENSE
├── MANIFEST.in
├── pytest.ini
├── README.md
├── scripts
│ ├── dockerBuild
│ ├── dockerRun
│ └── run
├── setup.cfg
├── setup.py
├── src
│ └── tesk_core/
├── taskmaster
├── tests/
└── tox.ini
32 directories, 109 files
THOUGHTS? PS: Please look at the current |
I don't really know how these scripts are used. There's probably room for improvement here and your proposal sounds reasonable. However, I don't really know how and where these scripts are currently used. In any case, I don't think it's a high priority issue right now and how to best organize these scripts (or the commands in them) will probably become clear(er) later on, so I wouldn't worry about that now. But perhaps @lvarin, @jemaltahir and/or @trispera have more insights here.
Sounds good, please go ahead with that.
I would not use capital letters for the package name, it's kinda against Python conventions. So rather use
Again, I would rather use the same structure that other FOCA apps are using, and they basically reproduce the package structure from the app. So instead of
Yes, just follow how this is organized in proTES etc. However, if you don't mind the clutter for now, you can also leave this for now and address this in #164 towards the end. This would have the advantage that it might actually still all be roughly functional without having to change anything. I don't have a strong opinion either way, as long as it's nice and clean in the end :) |
Follow basic structure of other FOCA apps, e.g., proTES and Cloud Registry.
In particular:
setup.py
)The text was updated successfully, but these errors were encountered: