Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add poetry #173

Merged
merged 14 commits into from
May 14, 2024
Merged

feat: add poetry #173

merged 14 commits into from
May 14, 2024

Conversation

JaeAeich
Copy link

@JaeAeich JaeAeich commented May 11, 2024

  • Add poetry as package management.
  • Add some CI check (commit-lint and merge conflicts)
  • CI lintand format using (ruff`)
  • Add mypy (to be added to CI and fixed in next PR)
  • Update Dockerfile (Image size increased by 34mb)

fixes #152 #153 #154 #155

@JaeAeich JaeAeich changed the base branch from master to makefile May 11, 2024 18:57
@JaeAeich JaeAeich requested a review from uniqueg May 12, 2024 11:43
@JaeAeich JaeAeich force-pushed the boilerplate branch 2 times, most recently from 70b5419 to d9ffbe8 Compare May 14, 2024 04:43
@JaeAeich
Copy link
Author

:)


# @pytest.mark.parametrize(
# 'path, url, ftype, expected, caplog_text',
# [
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test requires aws creds.

@JaeAeich JaeAeich requested review from lvarin and jemaltahir May 14, 2024 06:19
@JaeAeich JaeAeich changed the base branch from makefile to main May 14, 2024 06:27
@JaeAeich JaeAeich changed the base branch from main to makefile May 14, 2024 06:27
@JaeAeich
Copy link
Author

IG, changing the name of github actions workflow (to comply with other file name and repos) tripped it and its not showing tests, but all the tests passed. You can check it as well and I have simulated in on a clean ubuntu docker image just to be sure :)

@JaeAeich JaeAeich merged commit 5cd4940 into makefile May 14, 2024
2 checks passed
@JaeAeich JaeAeich deleted the boilerplate branch May 14, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants