-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to dec34 #1100
Open
cosmic-vagabond
wants to merge
13
commits into
main
Choose a base branch
from
feat/add-support-to-dec34
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+5,585
−4,338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmic-vagabond
had a problem deploying
to
coverage
January 7, 2025 18:34 — with
GitHub Actions
Failure
18 tasks
cosmic-vagabond
had a problem deploying
to
coverage
January 8, 2025 07:33 — with
GitHub Actions
Failure
…acyDec to work with decimal places less than -18
cosmic-vagabond
had a problem deploying
to
coverage
January 8, 2025 15:33 — with
GitHub Actions
Failure
cosmic-vagabond
had a problem deploying
to
coverage
January 8, 2025 15:51 — with
GitHub Actions
Failure
cosmic-vagabond
had a problem deploying
to
coverage
January 8, 2025 17:56 — with
GitHub Actions
Failure
cosmic-vagabond
had a problem deploying
to
coverage
January 8, 2025 18:59 — with
GitHub Actions
Failure
cosmic-vagabond
had a problem deploying
to
coverage
January 8, 2025 19:11 — with
GitHub Actions
Failure
cosmic-vagabond
had a problem deploying
to
coverage
January 9, 2025 07:26 — with
GitHub Actions
Failure
cosmic-vagabond
had a problem deploying
to
coverage
January 9, 2025 07:26 — with
GitHub Actions
Failure
cosmic-vagabond
had a problem deploying
to
coverage
January 9, 2025 14:57 — with
GitHub Actions
Failure
cosmic-vagabond
temporarily deployed
to
coverage
January 9, 2025 15:29 — with
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1100 +/- ##
==========================================
- Coverage 45.08% 44.70% -0.38%
==========================================
Files 967 972 +5
Lines 37017 37688 +671
==========================================
+ Hits 16688 16848 +160
- Misses 19023 19517 +494
- Partials 1306 1323 +17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What has Changed?
Add support to Dec34 type to handle up to 34 decimal places for price calculation using asset with high decimal precision (e.g. WETH 18 decimals)
Test results
EVM token price (0.004)
Swap estimation retrieves correct price and amount:
Inverse price accurate:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking changeDeployment Notes
Are there any specific considerations to take into account when deploying these changes? This may include new dependencies, scripts that need to be executed, or any aspects that can only be evaluated in a deployed environment.
Screenshots and Videos
Please provide any relevant before and after screenshots by uploading them here. Additionally, demo videos can be highly beneficial in demonstrating the process.